search

hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Rename OrganizationActivityFilters to DashboardActivityFilters #6460

Closed acelaya closed 1 month ago

acelaya commented 1 month ago

After a few comes and goes, I ended up with the conclusion that it would be easier to have different filtering components per section.

However, after starting to apply filters in the second ~second~ PR, I realized we can in fact reuse the components.

This PR renames the OrganizationActivityFilters component, to a more generic DashboardActivityFilters, so that it can be reused in places other than the organization section, without causing confusion.

robertknight commented 1 month ago

However, after starting to apply filters in the second second, I realized we can in fact reuse the components.

You mean second PR, right?

acelaya commented 1 month ago

However, after starting to apply filters in the second second, I realized we can in fact reuse the components.

You mean second PR, right?

Oops, yes 😅