hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Don't create H groups for empty (null) GUIDs #6613

Open marcospri opened 1 month ago

marcospri commented 1 month ago

See https://github.com/hypothesis/lms/pull/6612 for examples of the problem.

We don't seem to have launches from AI without a GUID.

This might be an issue for first launches on application instances where we don't correctly use the GUID from the launch and pick the old (null) value from the DB instead.

We currently check on every launch that the GUID has not changed, also include here a check to avoid cointinue for empty GUIDs just in case.