hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Expose assignment.is_gradable in the dashboard API #6867

Closed marcospri closed 1 day ago

marcospri commented 4 days ago

This is a potential fix for:

This will allow the FE to base the decision to show the "sync grades" button both on the feature flag (part of the JSConfig dictionary) and the current assignment's is_gradable value.

@acelaya Can you double check if this approach makes sense? I reckon we need both the FF in JSConfig and this new value. If the FF is enabled we'd still shouldn't show the button to sync grades for non-gradable assignments.

Also see:

Testing

https://hypothesis.instructure.com/courses/319/assignments/3308

acelaya commented 4 days ago

@acelaya Can you double check if this approach makes sense? I reckon we need both the FF in JSConfig and this new value. If the FF is enabled we'd still shouldn't show the button to sync grades for non-gradable assignments.

Yep, I think it makes sense. It's the only way to allow displaying auto-grading-related info without displaying the button to sync grades.

marcospri commented 1 day ago

@acelaya Can you double check if this approach makes sense? I reckon we need both the FF in JSConfig and this new value. If the FF is enabled we'd still shouldn't show the button to sync grades for non-gradable assignments.

Yep, I think it makes sense. It's the only way to allow displaying auto-grading-related info without displaying the button to sync grades.

Great, then I think we can merge this independently and tackle the FE side when there's some capacity for it.