hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Decide wording of buttons shown in grading mode #944

Open klemay opened 5 years ago

klemay commented 5 years ago

As part of our work on https://github.com/hypothesis/client/issues/1296, we discussed the wording of the button shown when a teacher is in grading mode and viewing annotations from the entire class:

image

@jaredpdesigns suggested this as an alternative:

Screen Shot 2019-08-28 at 10 04 23 AM

The discussion around this so far:

We need to decide:

klemay commented 5 years ago

My opinion:

seanh commented 5 years ago

FYI it's actually Show only Sebastien Maurice Flaubert currently, I had the words in the wrong order in my mockup above.

Alternative suggestion Filter by Sebastien Maurice Flaubert. (Based on the iOS Mail app, it says things like Filter by: Unread and Filter by: Flagged.)

seanh commented 5 years ago

The maximum allowed length of a username or display name is 30 chars. Sebastian Maurice Flaubert Esq is an example of a max length 30 chars name. If the other label has been changed from its current Everybody's annotations to Showing all (as in Jared's mockup) then the max length username fits with no further changes:

Screenshot from 2019-08-28 15-21-50

So suggestion: change Everybody's annotations to Showing all and leave it at that.

klemay commented 5 years ago

So suggestion: change Everybody's annotations to Showing all and leave it at that.

That's a +1 from me

dwhly commented 5 years ago

Agree