hypothesis / product-backlog

Where new feature ideas and current bugs for the Hypothesis product live
118 stars 7 forks source link

Add helpful errors when OneDrive files may be blocked by permission #1245

Open chrisshaw opened 2 years ago

chrisshaw commented 2 years ago

As an instructor creating a OneDrive assignment, I want the error message to tell me why it didn't work, so I know what step to take next

With the launch of OneDrive, many users may not be able to use the feature due to admin sharing restrictions. We have knowledge base articles describing this but users have no way to find this information in the middle of a flow when this breaks. This gives them helpful error messaging.

Flow

Inspired by this Slack thread and this Slack thread

mattdricker commented 2 years ago

Details on There was a problem choosing a file from OneDrive: e.value is undefined and There was a problem choosing a file from OneDrive: Cannot read properties of undefined (reading '0').

These errors are actually from the same underlying event. The former is shown in Firefox browser, the latter in Chrome.

They occur if a Microsoft 365 admin has implemented a policy forbidding sharing of files through OneDrive and/or SharePoint to anyone without requiring a sign-in.

Screen Shot 2022-01-28 at 11 55 30 AM

Instructors will see this error during assignment creation, after picking a PDF to use through the OneDrive picker.

Screen Shot 2022-01-28 at 1 18 51 PM Screen Shot 2022-01-28 at 1 17 56 PM
mattdricker commented 2 years ago

UX note: Ideally, Hypothesis would detect that sharing is restricted for the OneDrive account after the instructor logs on but before the instructor selects their PDF to use, allowing a message to be displayed before the OneDrive picker loads.

esanzgar commented 2 years ago

UX note: Ideally, Hypothesis would detect that sharing is restricted for the OneDrive account after the instructor logs on but before the instructor selects their PDF to use, allowing a message to be displayed before the OneDrive picker loads.

I see you point, but unfortunately that's not possible. The reason is that the login to OneDrive is driven by a the OneDrive picker. We can't add an intermediate step after login to verify the permissions.

mkdir-washington-edu commented 1 year ago

https://app.hubspot.com/contacts/6291320/ticket/1339140764