Closed dwhly closed 1 month ago
@robertknight You mentioned before what the issue was but I've lost the thread, so I created this stub to track.
https://hypothesis.vitalsource.com always configures the client assuming it is inside the LMS app. When you visit this directly, the client get stuck in a loading state because it is waiting for configuration from the LMS parent app that never arrives.
Ideally we would either have different domains for the different use cases (hypothesis-lms.vitalsource.com
vs hypothesis.vitalsource.com
) or pass some configuration in the launch URL which tells VitalSource whether to configure Hypothesis for use in the LMS or not.
Is the fix on our end or theirs in terms of how they embed the client.
+1 650 274 7647 m My calendar ( https://calendly.com/dwhly )
On Mon, Jul 22 2024 at 10:23 AM, Robert Knight < @.*** > wrote:
https://hypothesis.vitalsource.com always configures the client assuming it is inside the LMS app. When you visit this directly, the client get stuck in a loading state because it is waiting for configuration from the LMS parent app that never arrives.
— Reply to this email directly, view it on GitHub ( https://github.com/hypothesis/product-backlog/issues/1547#issuecomment-2242373241 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAKY7USAVELFFYNCVWODX3LZNS6P5AVCNFSM6AAAAABLHYZJLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSGM3TGMRUGE ). You are receiving this because you authored the thread. Message ID: <hypothesis/product-backlog/issues/1547/2242373241 @ github. com>
Is the fix on our end or theirs in terms of how they embed the client.
Changes will be needed on both sides, as we'd need to change from having just one configuration of the client within VitalSource (for use in the LMS), to somehow having two (for use inside and outside the LMS).
@janraev Updated repro steps:
Try in other chomium browsers Try with Bookmarklet, Via in other browsers
Janrae's reproductions here: https://hypothes-is.slack.com/archives/C2BLQDKHA/p1724164760282779
Bug report form
Steps to reproduce
Expected behaviour
The client should launch normally and allow annotation of the VS text.
Actual behaviour
Groups fail to load after log in without a refresh. See: https://hypothes-is.slack.com/archives/C4K6M7P5E/p1721982579405939?thread_ts=1721982156.699809&cid=C4K6M7P5E
Browser/system information
Modern chrome