hypothesis / product-backlog

Where new feature ideas and current bugs for the Hypothesis product live
118 stars 7 forks source link

Links to annotations made in EPUBS fail in Safari/Firefox #709

Open xolotl opened 6 years ago

xolotl commented 6 years ago

Related

EPUBS

Related to https://github.com/hypothesis/product-backlog/issues/1356

Related to https://github.com/hypothesis/product-backlog/issues/709

PDFs

Related to #1358

Related to https://github.com/hypothesis/product-backlog/issues/1360

Steps to reproduce

  1. Make an annotation in an epub (eg, using the Hypothesis EPUB demos).
  2. Using Safari or Firefox, navigate to any link provided by the annotation to return to the document (eg, the sharing link on the annotation, the view in context link in activity pages/search, etc).
  3. See the annotation bar load, but not the EPUB. Errors below.

Expected behaviour

When I click on a link to see an annotation in context, I should be taken to view that annotation in context in the EPUB in which it was made.

Browser/system information

Mac OS 10.13.5. Chrome Version 67.0.3396.99 (Official Build) (64-bit). Safari Version 11.1.1 (13605.2.8). Firefox 61.0.1 (64-bit).

Actual behaviour

Annotation made using Readium:

Annotation made using epub.js:

message: "File not found in the epub: http://fonts/STIXGeneral.otf"

stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:13206…"

Object Prototype

(anonymous function) (epub.min.js:1:109681)
promiseReactionJob

[Error] {message: "File not found in the epub: http://fonts/STIXGeneralItalic.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] {message: "File not found in the epub: http://fonts/STIXGeneralBol.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] {message: "File not found in the epub: http://fonts/STIXGeneralBolIta.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] {message: "File not found in the epub: http://images/9780316000000.jpg", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] {message: "File not found in the epub: http://css/stylesheet.css", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] {message: "File not found in the epub: http://images/Moby-Dick_FE_title_page.jpg", stack: "value@https://via.hypothes.is/js_/https://cdn.hypo…b.min.js:1:83907↵promiseReactionJob@[native code]"} (anonymous function) (epub.min.js:1:109681) promiseReactionJob [Error] Unhandled Promise Rejection: [object Object] (anonymous function) promiseReactionJob [Error] Unhandled Promise Rejection: Error: No Section Found (anonymous function) rejectPromise (anonymous function) (epub.min.js:1:33267) (anonymous function) promiseReactionJob

* Firefox errors:

Object { message: "File not found in the epub: http://fonts/STIXGeneral.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://fonts/STIXGeneralItalic.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://fonts/STIXGeneralBol.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://fonts/STIXGeneralBolIta.otf", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://images/9780316000000.jpg", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://css/stylesheet.css", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Object { message: "File not found in the epub: http://images/Moby-Dick_FE_title_page.jpg", stack: "value@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:132056\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109081\nvalue/t<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109627\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:109565\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:85149\nvalue@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:83890\nvalue/<@https://via.hypothes.is/js_/https://cdn.hypothes.is/demos/epub/epub.js/node_modules/epubjs/dist/epub.min.js:1:82003\n" } epub.min.js:1:109667 Error: No Section Found epub.min.js:1:60595 Loading failed for the Githubissues.

  • Githubissues is a development platform for aggregating issues.