hypothesis / proxy-server

serve third party webpages (currently limited to pdfs) with the hypothesis client embedded and configured
1 stars 0 forks source link

Use tox to automate installing Docker Compose #13

Closed seanh closed 4 years ago

seanh commented 4 years ago

While Docker itself needs to be installed manually (so Docker gets listed in the You will need section at the top of the README, for example see You will need in LMS's README), Docker Compose doesn't need to be installed manually and is instead installed automatically, using tox, in all Hypothesis projects. proxy-server should do the same. This means that:

The way automating Docker Compose installation is done is:

  1. Makefile commands run tox -e docker-compose ..., i.e. run docker-compose via tox instead of directly. For examples see https://github.com/hypothesis/lms/blob/cfa8fc9c85d270a3610d97f9a173fbe6100aa02f/Makefile#L28-L31 and https://github.com/hypothesis/lms/blob/cfa8fc9c85d270a3610d97f9a173fbe6100aa02f/Makefile#L53-L55

  2. tox.ini lists docker-compose as a dependency of the docker-compose tox environment: https://github.com/hypothesis/lms/blob/cfa8fc9c85d270a3610d97f9a173fbe6100aa02f/tox.ini#L56

  3. tox.ini lists docker-compose {posargs} as the command for the docker-compose tox environment: https://github.com/hypothesis/lms/blob/cfa8fc9c85d270a3610d97f9a173fbe6100aa02f/tox.ini#L78