search

hypothesis / support-legacy

a place for tracking support-related work and projects
3 stars 0 forks source link

Moodle's iframe when embedding LTI tools is small compared to the size of the embedded web page #160

Open mkdir-washington-edu opened 3 years ago

mkdir-washington-edu commented 3 years ago

Describe the bug It looks like Moodle is constraining the Hypothesis iframe, giving it a hard limit on height. This is reproducible in Chrome, Firefox, and Safari. It also affects an assignment made with a different LTI tool, so it's likely not a Hypothesis-specific issue.

Note that launching in a new window does not have this issue.

To Reproduce Steps to reproduce the behavior: Hypothesis example -

  1. Go to https://hypothesisuniversity.moodlecloud.com/mod/lti/view.php?id=283
  2. Resize screen as needed
  3. Note the iframe containing Hypothesis has a hard limit set on height that changes when resizing the window: <iframe id="contentframe" height="600px" width="100%" src="launch.php?id=283&amp;triggerview=0" allow="microphone ; camera ; geolocation ; midi ; encrypted-media ; autoplay " allowfullscreen="1" style="height: 292.688px;"></iframe>

Other LTI example:

  1. Go to https://hypothesisuniversity.moodlecloud.com/mod/lti/view.php?id=327&forceview=1
  2. Repeat test above

Expected behavior Users would expect to see more of the embedded page available to them, or to have the Hypothesis iframe extend to the bottom of the visible page.

Screenshots If applicable, add screenshots to help explain your problem. image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context It's worth noting that in the original Slack conversation I thought this was coming from an LMS user, but they were actually reporting an issue (that seems to do with how they zoom in) in a different LMS.

klemay commented 3 years ago

It also affects an assignment made with a different LTI tool, so it's likely not a Hypothesis-specific issue.

Before adding this to our backlog, I would suggest that the support team try to reach out to Moodle and ask about this– it's possible that hearing from our team will be enough to generate a ticket on their end. If that's not the case, we can have our developers file a ticket.