search

hypothesis / support-legacy

a place for tracking support-related work and projects
3 stars 0 forks source link

Share link generated for local PDF does not work and causes confusion #161

Closed mattdricker closed 3 years ago

mattdricker commented 4 years ago

Describe the bug When a user is annotating a local PDF, they are able to generate a share link. However, for very obvious reasons, this link does not work if it is shared with others (or simply used locally).

To Reproduce Steps to reproduce the behavior:

  1. Open a local PDF in browser and activate Hypothesis
  2. Click to create a link to share
  3. Attempt to load that address in a browser
  4. See error

Expected behavior Hard to say what the expected behavior might be. Perhaps alerting user that the file is local, and not generating a URL to share?

Additional context https://app.hubspot.com/contacts/6291320/ticket/244904105/

mattdricker commented 3 years ago

Looks like this may be resolved. Share link for annotations on local docs now open the annotation itself outside the document context.

mattdricker commented 3 years ago

Solved with https://github.com/hypothesis/client/issues/2786