hypothesis / support-legacy

a place for tracking support-related work and projects
3 stars 0 forks source link

LMS Files: long file names have the left side of the file name extend outside the view of the user #219

Closed mkdir-washington-edu closed 2 years ago

mkdir-washington-edu commented 2 years ago

Describe the bug When a PDF with a long file name is uploaded to the BB Files collection and an instructor uses the BB Files integration to view available PDFs (instructions here), it seems like the window that views the files can't handle long file names and is right- or center-justified.

Screen Shot 2021-08-27 at 11 07 28 AM

To Reproduce Steps to reproduce the behavior:

  1. Follow the directions to add a PDF to the course Content collection
  2. Use a file with a name like "What do we mean when we say, “Transformative learning experiences powered by technology” by Office of Ed Tech _ Medium.pdf"
  3. Create a new BB assignment and select the BB Files option
  4. See error

Expected behavior I think file names that extend beyond the window are fine if they are left-justified. We may also want to wrap long file names instead.

Desktop (please complete the following information):

mkdir-washington-edu commented 2 years ago

Changed the title because I saw the same issue in a user's Canvas instance: image

lyzadanger commented 2 years ago

@mkdir-washington-edu This ticket wasn't in the sprint and wasn't in a place I normally "look," so I had heard a rumor about it but never saw it directly. In any case, changes shipped as of https://github.com/hypothesis/lms/pull/3084 should make this better: long filenames are now elided with an ellipsis (...) and aren't "weird" like in the screengrab anymore.

If you would prefer that long filenames wrap to a second line instead of being truncated (doesn't look quite as elegant but isn't a disaster, either), that is a trivial change and I'd be glad to make it. Just let me know.

mkdir-washington-edu commented 2 years ago

From our conversation today, some users (especially those using the fingerprinting tool) have needed information at the end of the the file name, so a solution that wraps the file name so they can see the beginning and end of the file name is probably the best solution.