hypothesis / support-legacy

a place for tracking support-related work and projects
3 stars 0 forks source link

The LMS app URL option doesn't have a helpful error message for local files #230

Closed mkdir-washington-edu closed 2 years ago

mkdir-washington-edu commented 3 years ago

Describe the bug We've seen several tickets at the start of this year where the user attempts to use a local file address in the URL option in the LMS app. It would be helpful to users if we could display a specialized error message when this happens.

The current errror message looks something like "BadURL: No connection adapters were found for 'file:///C:/Users/tandy/Downloads/Invention%20through%20Process_Hodges.pdf'", but this isn't clear enough for many LMS app users.

To Reproduce Steps to reproduce the behavior:

  1. Open the LMS app
  2. Choose the URL option
  3. Input a local address like file:///C:/Users/tandy/Downloads/Invention%20through%20Process_Hodges.pdf
  4. See error

Expected behavior A better error message might be to point out that the address points to a file saved to their hard drive, and Hypothesis needs a file hosted online at either a public URL or in a compatible file storage solution (e.g. Google Drive, OneDrive, etc.).

Even if this only kicks in when the user actually begins the address with "file:///" it would be helpful.