hypothesis / support-legacy

a place for tracking support-related work and projects
3 stars 0 forks source link

Remove organization icon in the Sidebar from LMS groups #252

Closed mkdir-washington-edu closed 2 years ago

mkdir-washington-edu commented 2 years ago

Describe the bug image

Web app behavior: My understanding is that in the web app, when we have multiple publisher groups, we display them in the order of alphabetical by organization and then within each organization alphabetical by group. Also we add the organization's icon (when one exists) to the first group listed for that organization, but not subsequent groups.

LMS app behavior: The above behavior seems to be identical in the LMS app with the caveat that there's only a single organization. LMSs ask for icons for installed apps and historically we haven't had one, but now we do and provide it to installers. These icons are now showing up as organization icons for the first group, but not on any other groups in the Sidebar drop-down.

This is potentially confusing to users as there is no explanation why the Hypothesis icon appears on one group and not any other. Is that group privileged? Is it selected (even though I've selected a different group)? This is overall confusing behavior.

To Reproduce Steps to reproduce the behavior:

  1. Go to a Hypothesis install that has included an icon address in the installation (one example would be in course https://aunltd-test.blackboard.com/ultra/courses/_23_1/cl/outline and select the "Hypothesis" tool, not the "Hypothesis (Prod)" tool.
  2. Create a group assignment
  3. See error

Expected behavior Either all groups or no groups should have the icon so the user doesn't think there's a meaning implied by only one group having the icon.

Desktop (please complete the following information):

mkdir-washington-edu commented 2 years ago

Talking with @chrisshaw I'm going to add this to Harvestr and close this issue.