search

hypothesis / wordpress-theme-hypothesis

Hypothesis WordPress Theme
MIT License
5 stars 1 forks source link

Recommend `async` and `defer` attributes for `embed.js` script tag? #13

Closed BigBlueHat closed 9 years ago

BigBlueHat commented 9 years ago

I was checking out the Factlink.com "on your site" story: https://factlink.com/on-your-site#on-your-site-other-platforms

And noticed that their embed code includes async and defer attributes on script tags.

Both have wide browser support: http://caniuse.com/#feat=script-defer http://caniuse.com/#feat=script-async

Factlink also suggests putting their script tag "near the top of your document"--which is made possible by using these attributes.

I realize developers may know about them, but they're also really good at copy / paste, so...might be good to just include them regardless.

@hypothesis/developers thoughts?

tilgovi commented 9 years ago

Make it so.

BigBlueHat commented 9 years ago

Done: https://github.com/hypothesis/wordpress-theme-hypothesis/commit/c42691e92cb82aafc5dc26924eb9c9e961c3cb92

tilgovi commented 9 years ago

Cool. Feel free to deploy it.

tilgovi commented 9 years ago

Bump the version number, too (git tags).

BigBlueHat commented 9 years ago

Looks like Makefile stuff go pwnd during the upgrade. @RawKStar77 may know more.

There's no _style.css any longer (for instance).

I did tag a release: https://github.com/hypothesis/wordpress-theme-hypothesis/releases/tag/v2.0.1

My guess is that I could use the .zip file from GitHub, but would like to not be the one to test that. :wink:

@RawKStar77 if you still have a demo EC2 up, mind checkin' this change and publishing?

tilgovi commented 9 years ago

Looks like Jake didn't follow the readme or he would have noticed this and he would have pushed a tag.

Naughty Jake!