hypothesis / wordpress-theme-hypothesis

Hypothesis WordPress Theme
MIT License
5 stars 1 forks source link

Add new template, scripts and styles for the homepage #4

Closed aron closed 10 years ago

aron commented 10 years ago

This adds a new "Homepage" template to the theme that loads it's own specific styles and scripts. The content still needs to be added to a page in the Wordpress installation once this has been deployed.

Other changes include:

@tilgovi

JakeHartnell commented 10 years ago

Looks great. Nice work. :+1:

aron commented 10 years ago

@RawKStar77 did you work out the issue with the broken button?

JakeHartnell commented 10 years ago

@aron yes. The WordPress editor feels the need to inject extra br elements sometimes. I removed those and everything was grand.

aron commented 10 years ago

@RawKStar77 cool, I had hoped that the following lines would have fixed that.

https://github.com/hypothesis/hypothetheme/blob/139e1cb0f5dd4e587f20651b0441b4634fb12233/homepage.php#L17-L19

JakeHartnell commented 10 years ago

I think it was my fault, when I copied over frontpagemockup3 from our current site to my local install I copied it from view source since I was having a little trouble viewing the text when editing the page in wp-admin (there was slow internet in the cafe I was working in).

Those lines DO fix that. : )