search

hypothesis / wp-hypothesis

Hypothesis WordPress plugin
https://wordpress.org/plugins/hypothesis/
Other
29 stars 14 forks source link

UI Shouldn't Render on OEmbed Posts #16

Open mrjarbenne opened 8 years ago

mrjarbenne commented 8 years ago

Now that WP supports oembed for blog posts, the Hypothesis toolbar is being rendered multiple times, both on the sidebar, and in each oembed post.

If possible, the toolbar shouldn't be present in the oembed template because one wouldn't read annotations in that smaller viewport.

2016-08-29_21-47-08

robertknight commented 7 years ago

Hello,

We've made a start on some initial work to support documents which have other documents embedded via iframes which may be of help here. Do you have an example of a link to a post which uses OEmbed and Hypothesis?

mrjarbenne commented 7 years ago

Hi @robertknight. Here's the post from the screenshot, from a Multisite instance of WP, running the hypothes.is plugin (version 0.5.0). Sorry for the delayed response. Hope this helps:

https://mrjarbenne.ca/2016/03/25/innovation-vs-consistency/