search

hypothetical-inc / gaffer

Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.
http://imageengine.github.io/gaffer/
BSD 3-Clause "New" or "Revised" License
59 stars 3 forks source link

Some files seem to maybe be symlinks and don't resolve on Windows? #26

Open boberfly opened 3 years ago

boberfly commented 3 years ago

Version: Gaffer 0.59.0.0-beta windows Third-party tools: GafferDeadline (latest clone) Third-party modules: None

Description

Some files (maybe derived from a tarball?) seem to be some kind of pseudo symlink and fail on Windows

Steps to reproduce

  1. startup/dispatch/project.py
  2. startup/browser/ocio.py
  3. startup/view/ocio.py

(those are the obvious ones I've found so far)

Debug log

Click to Expand

``` ../../startup/gui/project.py ^ SyntaxError: invalid syntax ```

ericmehl commented 3 years ago

Thanks a lot for pointing that out @boberfly. I learned that git can maintain symlinks created on Linux in the repository itself and since Windows doesn't really support them properly it just puts the file name in the content instead.

I should be able to use a git command to find all of the symlink files and copy their source during build.

I don't have an ETA on when I can get to it, hopefully early next week.

ericmehl commented 3 years ago

Sorted this out with the (I think) added bonus of finally tidying up all of the path formatting to be OS-specific instead of relying on the fact that Windows allows cheating and using a forward slash in paths.

It will be included in the next release, probably 0.60.0.0 when that hits the GafferHQ releases.

ericmehl commented 3 years ago

Hey @boberfly, give the latest 0.59.4.0 release a try. It should fix the apps launching as well as updating to the latest HQ release as well. https://github.com/hypothetical-inc/gaffer/releases/tag/0.59.4.0