search

hypre-space / hypre

Parallel solvers for sparse linear systems featuring multigrid methods.
https://www.llnl.gov/casc/hypre/
Other
674 stars 185 forks source link

add the option of IJ base #1056

Closed liruipeng closed 7 months ago

liruipeng commented 8 months ago

This PR fixes the issue of the IJ interface on GPU when index base $\neq 0$

rfalgout commented 8 months ago

@liruipeng . This looks good to me so far. Let me know when you move it out of draft status.

One question/comment. If the ij_assembly.c routine is useful for testing, should we add a test to the regression suite? Same question for ij_device.c.

liruipeng commented 8 months ago

@liruipeng . This looks good to me so far. Let me know when you move it out of draft status.

One question/comment. If the ij_assembly.c routine is useful for testing, should we add a test to the regression suite? Same question for ij_device.c.

Thanks for the suggestion. Regression for ij_assembly.c was added. Not sure about ij_device.c, which was useful when we developed AMG on device but not so much right now. Maybe it can be removed.

rfalgout commented 8 months ago

Thanks for the suggestion. Regression for ij_assembly.c was added. Not sure about ij_device.c, which was useful when we developed AMG on device but not so much right now. Maybe it can be removed.

Awesome, thanks! Why are some of the files empty, though (e.g., fsai.jobs)?

victorapm commented 8 months ago

I think GitHub wanted to say that there aren't changes in any lines of the files. What has changed here are the file permissions, from 644 to 755

liruipeng commented 8 months ago

@rfalgout LANL tested this fix and it worked for them. This PR should be good to go. Thanks!