search

hypre-space / hypre

Parallel solvers for sparse linear systems featuring multigrid methods.
https://www.llnl.gov/casc/hypre/
Other
674 stars 185 forks source link

Thoroughly address #960 #1064

Closed prj- closed 8 months ago

prj- commented 8 months ago

See also: https://github.com/hypre-space/hypre/pull/896

prj- commented 8 months ago

I don't know why I never took the time to fix this @victorapm, but here you go (see referenced MR and/or issue for the current warnings I get without this patch).

victorapm commented 8 months ago

@rfalgout , Pierre fixed some compilation warnings like:

: warning #3012-D: a volatile destination type for a compound assignment expression is deprecated
              move_bucket->hopInfo &= ~(1U << move_new_free_dist);

Which happens when compiling with -std=c++20

liruipeng commented 8 months ago

What exactly is the problem? Is it |=, &=, etc, or startBucket->hopInfo? Thanks

rfalgout commented 8 months ago

What exactly is the problem? Is it |=, &=, etc, or startBucket->hopInfo? Thanks

Here is something I found explaining the issue:

https://stackoverflow.com/questions/65528802/incrementing-a-volatile-in-c20-with-operations-on-volatile-being-deprecated