search

hypre-space / hypre

Parallel solvers for sparse linear systems featuring multigrid methods.
https://www.llnl.gov/casc/hypre/
Other
651 stars 182 forks source link

Fix coarsen type #1080

Closed liruipeng closed 4 months ago

liruipeng commented 4 months ago

This PR removes a potential coarsen_type change in AMG setup on GPUs. The CPU code remains the same.

liruipeng commented 4 months ago

Interestingly, we got some "errors" on GPUs with this change, see below. So this means we actually hit that line of changing coarsen_type. Should we go ahead to change the .saved files?

(254) - Final Relative Residual Norm = 1.807958e-09
(254) + Final Relative Residual Norm = 1.802890e-09      (err 5.07e-12)

(262) - Final Relative Residual Norm = 1.807958e-09
(262) + Final Relative Residual Norm = 1.802890e-09      (err 5.07e-12)

(286) - Final Relative Residual Norm = 4.616163e-09
(286) + Final Relative Residual Norm = 7.693914e-09      (err 3.08e-09)

(294) - Final Relative Residual Norm = 7.457096e-09
(294) + Final Relative Residual Norm = 8.665192e-09      (err 1.21e-09)
rfalgout commented 4 months ago

Interestingly, we got some "errors" on GPUs with this change, see below. So this means we actually hit that line of changing coarsen_type. Should we go ahead to change the .saved files?

Just to document what we just talked about, yes I think you should change the .saved files. Thanks!