search

hypriot / flash

Command line script to flash SD card images of any kind
MIT License
1k stars 176 forks source link

Use predefined bs_size #120

Closed arrelid closed 6 years ago

arrelid commented 6 years ago

Before this change, this wouldn't run on macOS.

StefanScherer commented 6 years ago

I use flash on macOS, so I wonder why this change is needed.

jppurcell9 commented 6 years ago

I just ran into this myself. The error only occurs when pv is not installed. The change is needed because macOS expects a lowercase m in the block size argument to dd (1m instead of 1M). The else branch here is hit when pv is not installed, and has the block size hard-coded instead of using the bs_size var.

StefanScherer commented 6 years ago

Thanks for clarification. LGTM. Thanks @arrelid