hypriot / flash

Command line script to flash SD card images of any kind
MIT License
1k stars 176 forks source link

Prevent mistaking inherited environment variables as arguments #167

Open kittydoor opened 4 years ago

kittydoor commented 4 years ago

In my shell profile, I set a variable called "FILE" which points to my file manager of choice. Same thing with "BROWSER", "EDITOR", etc.

However, flash doesn't take into account that a generic name like FILE might already exist in the environment, and mistakes it for an argument passed to itself.

Setting values to a default (e.g. ""), would resolve this and simiilar unexpected behaviour.