search

hypriot / flash

Command line script to flash SD card images of any kind
MIT License
1.01k stars 175 forks source link

maintain a homebrew package for flash #173

Closed onedr0p closed 4 years ago

onedr0p commented 4 years ago

The install instructions are pretty easy, but it would be nice to have a homebrew package for updating.

onedr0p commented 4 years ago

If it's helpful, this is how it is done for kubetail which is also a bash script

https://github.com/johanhaleby/kubetail

Instructions state: brew tap johanhaleby/kubetail && brew install kubetail

Looks like we would need to add a hypriot/homebrew-flash repo like the following...

https://github.com/johanhaleby/homebrew-kubetail

Is this something the maintainers are interested in?

StefanScherer commented 4 years ago

Thanks for the suggestion. There is a pull request https://github.com/Homebrew/homebrew-core/pull/52503 which you can follow.

witsch commented 4 years ago

Unfortunately, getting the pull request (or rather the required test) to be in an acceptable form turned out to be a bit tricky. Now it should be okay, but it might take another bit for the maintainers to get back to it… 🙂

onedr0p commented 4 years ago

No worries, the homebrew maintainers are super stingy on most everything. There's always the way I listed above if they don't approve it. :)

StefanScherer commented 4 years ago

It just landed, thanks @witsch !!! 🎉🎉 I couldn't believe this was possible 😅

brew-install-flash
witsch commented 4 years ago

You're welcome, I'm glad I could contribute a little bit… and hey, now it's only one step to get a new Pi running! Well, almost… 🙂

StefanScherer commented 4 years ago

Ping @witsch I don't remember if the homebrew flash formula gets updated automatically. I just released version 2.7.1 https://github.com/hypriot/flash/releases/tag/2.7.1 🤗

witsch commented 4 years ago

Pong 🙂

They're not, but updating has become very convenient by now. So in this case — and this is mostly meant as a 'note to self' — all that's needed to create https://github.com/Homebrew/homebrew-core/pull/55634 was:

$ brew bump-formula-pr --url https://github.com/hypriot/flash/releases/download/2.7.1/flash --sha256 …
StefanScherer commented 4 years ago

Thank you @witsch ! This already creates the PR in homebrew-core?

Do you know if I can run this on Linux here in our pipeline? -> https://github.com/hypriot/flash/blob/master/.circleci/config.yml#L55

witsch commented 4 years ago

Yes, it does. I'm not sure how easily it integrates in CI, though. It needs your Github credentials, of course, but then again perhaps all you need is a token in the environment? Would you let me know if you get it to work, please? 🙂