search

hypriot / flash

Command line script to flash SD card images of any kind
MIT License
1k stars 176 forks source link

Feature/improve drive id retrieval #175

Open kremerol opened 4 years ago

kremerol commented 4 years ago

I am using hypriot flash utility to flash hypriot images, but also other other images, for which the 'FAT' partition is not always the first one: for instance, the disk image for the rock-64 arm device (https://github.com/ayufan-rock64/linux-build/releases/download/0.8.3/bionic-minimal-rock64-0.8.3-1141-arm64.img.xz) has 7 partitions, and the FAT partition is number 6. Therefore, I have improved the way to retrieve this partition id (I search for the first MSDOS partition). I did some successful test on linux and on mac (but of course, not with every possible situation). I will be happy to see this code in a next official hypriot/flash release.

StefanScherer commented 4 years ago

@kremerol Thank you for the contribution. Some tests fail on CircleCI if you could have a look.

kremerol commented 4 years ago

@StefanScherer - done