Filter correct disk ID in Linux

hypriot / flash

Command line script to flash SD card images of any kind

MIT License

1.01k stars 173 forks source link

Filter correct disk ID in Linux #27

Closed MathiasRenner closed 8 years ago

MathiasRenner commented 8 years ago

This PR is based on top of the idea of https://github.com/hypriot/flash/pull/21. This PR now correctly selects SD cards with mmcblk... identifier as well as USB-SD reader identified via sdb... when using the flash tool in Linux.

@firecyberice Please test this on your machine.

MathiasRenner commented 8 years ago

I also tested this fix with setting a host name in addition (--hostname). Works fine.

Anyone else out there with a Linux machine who can confirm it works?

StefanScherer commented 8 years ago

Can you please squash the PR?

git rebase -i $(git merge-base $(git rev-parse --abbrev-ref HEAD) master)

Then beginning from line 2 replace "pick" to "squash", so leave the first "pick". Reduce the commit comment to the first one. Then

git push -f origin $(git rev-parse --abbrev-ref HEAD)

MathiasRenner commented 8 years ago

@StefanScherer Squashing done.

StefanScherer commented 8 years ago

LGTM!