search

hyprland-community / hyprland-rs

An unofficial rust wrapper for hyprland's IPC [maintainers=@yavko,@cyrinux]
Other
252 stars 56 forks source link

fix: updated getoption logic for Hyprland v0.36 #203

Closed JarKz closed 7 months ago

JarKz commented 7 months ago

The new Hyprland version (at this moment - 0.36) have changed the getoption command, where value can be either a str, an int or a float. So with old logic the Serde expects an int or a float (firstly integer), but there it doesn't exists.

I marked these values as Option\<T> and changed logic in parsing keyword.

I'm not sure about edge cases, so I'm open to another opinions.

Fixes issue #184 .

JarKz commented 7 months ago

Also, I added simple tests for check this. Add they to repo or not?

yavko commented 7 months ago

Also, I added simple tests for check this. Add they to repo or not?

make new pr