Add the excludes_stash feature for scratchpads

hyprland-community / pyprland

Scratchpads & many goodies for Hyprland [maintainer=@fdev31]

MIT License

406 stars 17 forks source link

Add the excludes_stash feature for scratchpads #126

Closed axelKeizoStahl closed 4 months ago

axelKeizoStahl commented 4 months ago

The feature is described in issue #123 : After a scratch that excludes windows is hidden, any scratches it made hide return to the screen.

Implementation:

Add excluded_scratches property to the Scratch class.
If excludes_stash is set true in config, put excluded scratches in excluded_scratches property.
When this scratchpad is closed, the scratches in excluded_scratches are shown.

fdev31 commented 4 months ago

What do you think about restore_excluded instead of excludes_stash for the config option?

axelKeizoStahl commented 4 months ago

I've changed the code based on your comments, let me know of anything else. :+1:

fdev31 commented 4 months ago

Looks good now, I'll merge,but I don't really like the name, do you mind if I rename the option to restore_excluded after the merge?

Some alternatives:

remember_excluded
stash_hidden
excluded_memory
track_excluded
transient ?
restore_on_hide / restore_when_hidden
...

axelKeizoStahl commented 4 months ago

I think restore_excluded is the most descriptive and fitting, that would be great, thanks!

fdev31 commented 4 months ago

Check https://hyprland-community.github.io/pyprland/scratchpads_advanced.html#restore-excluded and feel free to comment! Thank you for your contribution!