hyprland-community / pyprland

Scratchpads & many goodies for Hyprland [maintainer=@fdev31]
MIT License
345 stars 15 forks source link

[BUG] Invalid json data at pypr startup #96

Closed JohnRTitor closed 4 months ago

JohnRTitor commented 4 months ago

Pyprland version 2.2.14-10

Describe the bug pyprland shows invalid json data error when launched at startup.

To Reproduce

  1. Launch pypr at startup using exec-once=pypr
  2. Relogin
  3. See the error

Expected behavior No error.

Configuration (provide following files/samples when relevant):

Additional context OS: NixOS I am using the flake to get the git version.

IMG_20240429_121214

fdev31 commented 4 months ago

How am I supposed to report this error then? Shouldn't the nix package be fixed instead?

Edit: can you confirm pyprland works as expected?

JohnRTitor commented 4 months ago

Yes. pyprland works as expected. This is likely a regression from 2.2.12 after which the version check is added. I can confirm it works on 2.2.5.

And I am using pyprland from this repository's flake (built from this commit), not from nixpkgs.

fdev31 commented 4 months ago

So you confirm there is no issue in pyprland, but rather in the Hyprland package you are using. Please install a non-broken Hyprland package which doesn't create invalid JSON.

JohnRTitor commented 4 months ago

Indeed, it seems so, checking hyprctl version -j shows

{
    "branch": "",
    "commit": "b164e67d8b1f12420ec44a1c837af7923559ccf2",
    "dirty": false,
    "commit_message": "",
    "commit_date": "2024-04-28",
    "tag": "",
    "commits": @COMMITS@,
    "flags": []
}

This is what causing the errors.

    "commits": @COMMITS@,
fdev31 commented 4 months ago

You can try to report a bug to the packager... but I don't want to hide such big problem when found...

JohnRTitor commented 4 months ago

Should be fixed by https://github.com/hyprwm/Hyprland/commit/39595aaca3c16cc483dcaacdebaecc24c952246b