Change to the last opened workspace feature

hyprwm / Hypr

Hypr is a tiling window manager written in modern C++.

BSD 3-Clause "New" or "Revised" License

1.06k stars 32 forks source link

Change to the last opened workspace feature #33

Closed imaphatduc closed 2 years ago

imaphatduc commented 2 years ago

Done tasks:

[x] Create everything needed for the feature (including definitions and methods).
[x] Reuse the codes from CWindowManager::changeWorkspaceByID method.
Bugs:
False behavior when switching from the workspace that has windows opened and the one that don't have any windows.
Question about the bug: I don't know if that's because my own logic bugs or there are some parts implicitly included in your code. (very likely that I missed some implemented ideas of the reused method)
TODO:
Fix the bug and ready for a complete PR.

vaxerski commented 2 years ago

fixed. thanks for the pr!

imaphatduc commented 2 years ago

Hey, I just want to say that your project is awesome. But imo, some of your namings are a little ambiguous. Still now, I'm not sure about the difference between workspaces and activeworkspaces (I think activeworkspaces includes the IDs of the active workspaces, if so you can change its name to activeworkspacesIDs for example).

vaxerski commented 2 years ago

they are, fair. I could include some comments.

hyprwm / Hypr

Change to the last opened workspace feature #33

Done tasks:

Bugs:

TODO: