Can't shift some keys when using non-us keyboard layout

felipeagc commented 1 year ago

For some reason I can't shift a lot of the keys on the 'br' keyboard layout, like ',', '.', ';', '/' or any other accent or special character for example. This is the keyboard layout for reference:

If someone could give some pointers on where this is handled in the code I could debug it and submit a PR. Thanks in advance!

EDIT: this is on 0.18.0

vaxerski commented 1 year ago

I am unsure whether this is handled by Hyprland. Afaik, xkb should deal with this.

felipeagc commented 1 year ago

That's strange, because it works fine on sway

MahouShoujoMivutilde commented 1 year ago

@felipeagc how are you configuring your layout?

I've tried

input {
    # notice that `us` is first, this matters for hotkeys, at least when using non-latin layouts
    kb_layout = us,br
    kb_options = caps:escape,grp:alt_shift_toggle
}

and it works fine for me, àĉĉèǹtś.

felipeagc commented 1 year ago

@felipeagc how are you configuring your layout?

I've tried
input {
    # notice that `us` is first, this matters for hotkeys, at least when using non-latin layouts
    kb_layout = us,br
    kb_options = caps:escape,grp:alt_shift_toggle
}
and it works fine for me, àĉĉèǹtś.

Hmmm this still didn't work, it just changed the keyboard layout to the US one, and shift still didn't work. What did work was switching to another keyboard (also with the br layout), which is really weird.

This is the output of hyprland devices:

mice:
    Mouse at 82e64140:
        CM Storm Quickfire TKL Nkeys Consumer Control
            default speed: 0.000000
    Mouse at 82da35a0:
        Logitech MX518 Gaming Mouse
            default speed: 0.000000
    Mouse at 82c96470:
        Logitech MX518 Gaming Mouse Keyboard
            default speed: 0.000000

Keyboards:
    Keyboard at 82ca2b80:
        Power Button
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82c4f0a0:
        Video Bus
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82c9cc90:
        Video Bus
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82c70b40:
        Power Button
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82c65db0:
        Burr-Brown from TI               USB Audio CODEC
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82c595d0:
        CM Storm Quickfire TKL Nkeys
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82ba2940:
        CM Storm Quickfire TKL Nkeys Consumer Control
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82e965e0:
        CM Storm Quickfire TKL Nkeys System Control
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82eae700:
        CM Storm Quickfire TKL Nkeys Keyboard
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82f16740:
        Logitech MX518 Gaming Mouse Keyboard
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 82f54560:
        USB Live camera: USB Live camer
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 8319df60:
        Dell KB216 Wired Keyboard Consumer Control
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 8318f000:
        Dell KB216 Wired Keyboard System Control
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: no
    Keyboard at 832df9a0:
        Dell KB216 Wired Keyboard
            rules: r "", m "", l "br", v "", o ""
            active keymap: Portuguese (Brazil)
            main: yes

Tablets:

Touch:

Switches:

The keyboard that's working fine is the Dell one, while shift doesn't work on the CM Storm. Both have the physical brazilian keyboard layout.

On sway I configured the CM Storm's layout like this and it worked ok:

input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_Consumer_Control" xkb_layout br
input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_System_Control" xkb_layout br
input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_Keyboard" xkb_layout br
input "9494:20:CM_Storm_Quickfire_TKL_Nkeys" xkb_layout br

MahouShoujoMivutilde commented 1 year ago

it just changed the keyboard layout to the US one

Yeah, two layouts, when you want to switch between them - press alt+shift.

and shift still didn't work.

At this point I would be tempted to ask "does the key actually work?", but since you said it works in sway, IDK.

Hm, so you use br as a single layout, that's the only difference I see.

my devices

``` mice: Mouse at cd52eb50: Razer Razer DeathAdder default speed: 0.000000 Mouse at cd4dc4a0: Logitech USB Keyboard Consumer Control default speed: 0.000000 Keyboards: Keyboard at cd411010: Power Button rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: no Keyboard at cd4d0710: Power Button rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: no Keyboard at cd4d8550: Logitech USB Keyboard rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: no Keyboard at cd5a9810: Logitech USB Keyboard Consumer Control rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: no Keyboard at cd5f1100: Logitech USB Keyboard System Control rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: no Keyboard at cd630cf0: Eee PC WMI hotkeys rules: r "", m "", l "br", v "", o "caps:escape,grp:toggle" active keymap: Portuguese (Brazil) main: yes Tablets: Touch: Switches ```

But even with the single layout it still works for me !@#$%<>:Çãñâ

Weird.

I know about quirk with hyprland's own bindings when first layout is not us (as an extreme example - ru, when every alphabetic key is non latin), and if you define your bindings as in us, it wont work (even if us is present in kb_layout). (That can be worked around with keycodes, BTW).

I thought it might be related, but I am out of ideas, sorry.

vaxerski commented 1 year ago

On sway I configured the CM Storm's layout like this and it worked ok: input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_Consumer_Control" xkb_layout br input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_System_Control" xkb_layout br input "9494:20:CM_Storm_Quickfire_TKL_Nkeys_Keyboard" xkb_layout br input "9494:20:CM_Storm_Quickfire_TKL_Nkeys" xkb_layout br

device:CM Storm Quickfire TKL Nkeys Consumer Control {
    kb_layout=br
 }

??????????? https://wiki.hyprland.org/Configuring/Keywords/#per-device-input-configs

I know about quirk with hyprland's own bindings when first layout is not us (as an extreme example - ru, when every alphabetic key is non latin), and if you define your bindings as in us, it wont work (even if us is present in kb_layout). (That can be worked around with keycodes, BTW).

Thats why you should switch layouts per-device

MahouShoujoMivutilde commented 1 year ago

Thats why you should switch layouts per-device

Very nice, thank you.