allow_workspace_cycles does the opposite of what it says

hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.

https://hyprland.org

BSD 3-Clause "New" or "Revised" License

20.7k stars 874 forks source link

allow_workspace_cycles does the opposite of what it says #2547

Open tcmal opened 1 year ago

tcmal commented 1 year ago

The default behaviour (binds:allow_workspace_cycles = false) actually allows workspace cycles to be created, whereas setting it to true disallows this.

Since changing this would silently break a lot of configs, maybe it would be better to add a newly named property and deprecate the old one.

===== SYSTEM INFO: =====
System name: Linux
Node name: casper
Release: 6.1.31
Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue May 30 13:03:33 UTC 2023

izmyname commented 2 weeks ago

Hasn't this option been deprecated/replaced already? I can't find this setting's description on the wiki.

MahouShoujoMivutilde commented 2 weeks ago

It's still there https://wiki.hyprland.org/Configuring/Variables/#binds

allow_workspace_cycles

If enabled, workspaces don’t forget their previous workspace, so cycles can be created by switching to the first workspace in a sequence, then endlessly going to the previous workspace.

In practice, it works like this

bind = SUPER, Tab, workspace, previous

If allow_workspace_cycles is true, going

1 -> 2 -> 3, and pressing super+tab 2 times will result in going 3 -> 2 -> 1.

If false - 3 -> 2 -> 3 (i3 back and forth behavior)