hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.
https://hyprland.org
BSD 3-Clause "New" or "Revised" License
21.04k stars 880 forks source link

extend_border_grab_area does not work on tiled borders #2885

Open PatrickShaw opened 1 year ago

PatrickShaw commented 1 year ago

Hyprland Version

Hyprland, built from branch  at commit da0c74cdf038692377eb77fbfc57067c633467c0  ().
Tag: ?

flags: (if any)
debug

Bug or Regression?

Bug

Description

extend_border_grab_area only works when a window is floating. If the window is tiled, this option seems to be ignored

How to reproduce

  1. Set:
general {
    resize_on_border = true
    extend_border_grab_area = 10000
}
  1. Add some tiled windows
  2. Try resize on the border of one of those windows
  3. You'll notice that there is no extended grab area
  4. Now make one of the tiles float
  5. You'll notice that you can pretty much resize anywhere outside of window since the grab area is so far extended

Crash reports, logs, images, videos

Happy to add a recording on request but figured it's simple enough to replicate.

MightyPlaza commented 1 year ago

pretty sure it goes to the end of the node, so the middle of the tiled windows

MightyPlaza commented 1 year ago

@vaxerski should this be closed?

cypresslf commented 1 year ago

@MightyPlaza can you elaborate no what you mean by this? I'm seeing the same behavior as described in the issue, where extend_border_grab_area does nothing if my windows are tiled, but works if they are floating.

pretty sure it goes to the end of the node, so the middle of the tiled windows

Hyprland, built from branch main at commit e4d6695375ee8bc4250543ec8e2f372d6b52f2a9 dirty (keybinds: focus last window on workspace change to another mon). Tag: v0.29.1-89-ge4d66953

MightyPlaza commented 1 year ago

if you remove all borders, and gaps the window would occupy the full node, this is the area you have for resize on border the extent doesn't apply here

PatrickShaw commented 10 months ago

@MightyPlaza Ah, thank you for explaining how extend_border_grab_area is meant to work.

@cypresslf In case it's of any help: I believe the intended purpose of extend_border_grab_area is to only allow the "grab" in areas that do not overlap with the window.

PatrickShaw commented 10 months ago

Could we add an option to extend the grab area over windows?

I prefer very narrow visual borders but doing so becomes fairly impractical to resize - Particularly if you're using a touchpad

MightyPlaza commented 10 months ago

Could we add an option to extend the grab area over windows?

I prefer very narrow visual borders but doing so becomes fairly impractical to resize - Particularly if you're using a touchpad. recording_2023-12-03-020438.mp4

how do you propose that would be done? you would be unable to interact in the main window in the extended region

ntnn commented 4 months ago

I prefer very narrow visual borders but doing so becomes fairly impractical to resize - Particularly if you're using a touchpad

If you have this in your config:

bindm = $mainMod, mouse:273, resizewindow

You can resize tiled windows while holding mainMod and the right mouse button even when they're tiled.

izmyname commented 2 months ago

Should it be closed?

emerson-matos commented 2 months ago

maybe? #7214