hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.
https://hyprland.org
BSD 3-Clause "New" or "Revised" License
19.69k stars 832 forks source link

Glitches after GPU fix update #4744

Closed niksingh710 closed 7 months ago

niksingh710 commented 7 months ago

Hyprland Version

System/Version info ```sh Hyprland, built from branch main at commit 301b48b74087cc59753ffa144b215540e6f82831 dirty (renderer: fix invalid damage accumulation with invalid buffer_age). Date: Sun Feb 18 21:34:08 2024 Tag: v0.35.0-49-g301b48b7 flags: (if any) System Information: System name: Linux Node name: mach Release: 6.7.5-zen1-1-zen Version: #1 ZEN SMP PREEMPT_DYNAMIC Sat, 17 Feb 2024 14:02:21 +0000 GPU information: 00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-U GT2 [UHD Graphics] [8086:9b41] (rev 02) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Bug or Regression?

Bug

Description

Some time launching applications seeing artifacts of glitches.

How to reproduce

After the discord announcement of gpu

considerable gpu performance hit from a commit introduced in v0.33.0 has been fixed in git. i updated hyprland-git.

Now launching apps like firefox sometime show glitches before rendering it is so fast that m failing to take screenshot. will attach if got any.

Crash reports, logs, images, videos

No response

Fxzzi commented 7 months ago

My bad gang, I tested on latest git first and it didn't fix, so assumed it was like previous instructions. :)

vaxerski commented 7 months ago

what you mean didnt fix it? Or are you incapable of reading the patch is only meant for ON-SCREEN flicker and NOT screencopy??

vaxerski commented 7 months ago

d62e7a5125c551fe8a94e076e64d42b702d923b1 and e793f10b8bd1685a2e2bbd7cc90063f12bf380c4 fix both issues. Fix for screencopy fucking sucks but I give up writing a better one after 2 or so hours.

Fxzzi commented 7 months ago

Thanks for fixing the issues vax, take your time on the better fix, at least it's working fine now :)

vaxerski commented 7 months ago

chatted with wayland bois and I dont think the better fix is worth it due to.... wheyland

anyways closing fuck you all and I'll see you next time

rurigk commented 7 months ago

Both of them works for me

niksingh710 commented 7 months ago

I am currently on

Hyprland, built from branch main at commit 86be75dd97b5633b8c0aa6bdcb3346fa871a8480 dirty (events: bring back accidentally nuked preConfigReload).
Date: Tue Feb 20 08:54:15 2024
Tag: v0.35.0-59-g86be75dd

flags: (if any)

updated from AUR i face glitches sometime in foot terminal is there someother way to build to get fixed or the issue is there ?

niksingh710 commented 7 months ago

here after rebuild from aur image facing this on foot till only for now.

Fxzzi commented 7 months ago

hello again vax. Seems your fixes may have solved in some cases but I seem to be experiencing the issue(s) still on my Thinkpad L14 (AMD CPU and iGPU)

image

Anything you need me to test? Once again sorry for the trouble

vaxerski commented 7 months ago

there are two issues here and I want you to not mix those up.

One is visible on-screen, one is only visible on recordings. Which are you talking about

niksingh710 commented 7 months ago

there are two issues here and I want you to not mix those up.

One is visible on-screen, one is only visible on recordings. Which are you talking about

for me i am talking about visible on screen. it happens on foot terminal mostly. or sometimes when i launch firefox.

and at recording part. if I try to take screenshot when the screen is glitching https://github.com/hyprwm/Hyprland/issues/4744#issuecomment-1953563728 happens.

the glitch on the screen less compare to what comes in screenshot.

Fxzzi commented 7 months ago

there are two issues here and I want you to not mix those up.

One is visible on-screen, one is only visible on recordings. Which are you talking about

Yep, I understand. No issues afaik on screen. Issues with screencopy, aka OBS and Grim.

vaxerski commented 7 months ago

@niksingh710 your issue looks more like your gpu drivers crying than anything else. Nvidia?

@Fxzzi can you fiddle with your config on your laptop and see if any options solve the problem?

Fxzzi commented 7 months ago

@Fxzzi can you fiddle with your config on your laptop and see if any options solve the problem?

For sure, I'll have a look for you when I can. I assume it'll just be something in Hyprland config?

For ref, here are all of my configs https://gitlab.com/fazzi/dotfiles

vaxerski commented 7 months ago

yeah, try stuff like making your monitors at 0x0, changing res, maybe fiddle with rendering-related options

niksingh710 commented 7 months ago

@vaxerski

Hyprland, built from branch main at commit 86be75dd97b5633b8c0aa6bdcb3346fa871a8480 dirty (events: bring back accidentally nuked preConfigReload).
Date: Tue Feb 20 08:54:15 2024
Tag: v0.35.0-59-g86be75dd

flags: (if any)

System Information:
System name: Linux
Node name: mach
Release: 6.7.5-zen1-1-zen
Version: #1 ZEN SMP PREEMPT_DYNAMIC Sat, 17 Feb 2024 14:02:21 +0000

GPU information: 
00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-U GT2 [UHD Graphics] [8086:9b41] (rev 02) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:
  hypr-darkwindow by micha4w ver 1.0.0
  hycov by DreamMaoMao ver 0.3

This is my systeminfo from hyprland.

I have intel i7 10 gen cpu and Amd GPU (AMD Radeon 530 Series)

Have tested this on the previous build and I don't face an issue, so I don't think should be a driver

niksingh710 commented 7 months ago

yesterday i tried the latest commit in one of my friends laptop he is having nvidia 1650 for him everything was working fine. tears if nvidia_tear variable is false but the fps is 60 and if nvidia_tear is true then no tear but fps is 30. (on kde wayland too he get's 30 fps on monitor screen)

Fxzzi commented 7 months ago

yeah, try stuff like making your monitors at 0x0, changing res, maybe fiddle with rendering-related options

after fiddling a bit, it seems having waybar running and visible seems to break the screenshots. Here is my testing:

Minimal config:

```hyprlang monitor = eDP-1,1920x1080@60,0x0,1 # Set display to max res, auto offset $MOD = SUPER bind = , Print, exec, screenshot.sh --monitor bind = , XF86Launch2, exec, screenshot.sh --selection bind = SHIFT, Print, exec, screenshot.sh --active binde=, XF86AudioRaiseVolume, exec, audio.sh vol up 5 binde=, XF86AudioLowerVolume, exec, audio.sh vol down 5 binde=, XF86AudioMute, exec, audio.sh vol toggle binde=, XF86AudioMicMute, exec, audio.sh mic toggle binde=, XF86MonBrightnessUp, exec, brightness.sh up 5 binde=, XF86MonBrightnessDown, exec, brightness.sh down 5 bind = $MOD, T, exec, foot bind = $MOD SHIFT, E, exec, pkill wleave || wleave --protocol layer-shell -b 5 -T 360 -B 360 bind = $MOD SHIFT, R, exec, hyprctl reload bind = $MOD, Q, killactive bind = $MOD, Space, fullscreen bind = $MOD, Tab, togglefloating bind = $MOD, P, pseudo # dwindle bind = $MOD, S, togglesplit # dwindle bind = $MOD, left, movefocus, l bind = $MOD, right, movefocus, r bind = $MOD, up, movefocus, u bind = $MOD, down, movefocus, d bind = $MOD SHIFT, left, movewindow, l bind = $MOD SHIFT, right, movewindow, r bind = $MOD SHIFT, up, movewindow, u bind = $MOD SHIFT, down, movewindow, d binde = $MOD CTRL, left, resizeactive, -10 0 binde = $MOD CTRL, right, resizeactive, 10 0 binde = $MOD CTRL, up, resizeactive, 0 -10 binde = $MOD CTRL, down, resizeactive, 0 10 bind = $MOD, 1, workspace, 1 bind = $MOD, 2, workspace, 2 bind = $MOD, 3, workspace, 3 bind = $MOD, 4, workspace, 4 bind = $MOD, 5, workspace, 5 bind = $MOD, 6, workspace, 6 bind = $MOD, 7, workspace, 7 bind = $MOD, 8, workspace, 8 bind = $MOD, 9, workspace, 9 bind = $MOD, 0, workspace, 10 bind = $MOD ALT, up, workspace, e+1 bind = $MOD ALT, down, workspace, e-1 bind = $MOD SHIFT, 1, movetoworkspace, 1 bind = $MOD SHIFT, 2, movetoworkspace, 2 bind = $MOD SHIFT, 3, movetoworkspace, 3 bind = $MOD SHIFT, 4, movetoworkspace, 4 bind = $MOD SHIFT, 5, movetoworkspace, 5 bind = $MOD SHIFT, 6, movetoworkspace, 6 bind = $MOD SHIFT, 7, movetoworkspace, 7 bind = $MOD SHIFT, 8, movetoworkspace, 8 bind = $MOD SHIFT, 9, movetoworkspace, 9 bind = $MOD SHIFT, 0, movetoworkspace, 10 bindm = $MOD, mouse:272, movewindow bindm = $MOD, mouse:273, resizewindow bind = $MOD, mouse_down, workspace, e+1 bind = $MOD, mouse_up, workspace, e-1 ```

no issues with screenshots or video recording on this minimal config

Now for my config: https://gitlab.com/fazzi/dotfiles/-/raw/hyprland-laptop/.config/hypr/hyprland.conf

Issue with screenshots: Screenshot from 24 02 20 14:07:54

However, strangely, screen recording seems fine: image

Killing waybar and screenshots seem fixed from what I can tell: Screenshot from 24 02 20 14:07:21

I tested whether or not it was some issue with the waybar reserved area, however doesn't seem like it, as adding monitor = eDP-1,addreserved,40,0,0,0 with waybar killed and screenshots are still good Screenshot from 24 02 20 14:09:07

vaxerski commented 7 months ago

patch.txt le try

Fxzzi commented 7 months ago

le try

seems to be le fixed :) Screenshot from 24 02 20 15:09:36

vaxerski commented 7 months ago

committed

niksingh710 commented 7 months ago

committed

screen copy wasn't an issue for me updated to latest commit sometimes still i see artifacts on foot terminal After updating to latest git commit my laptop screen had abit of artifact but as cursor went their it cleaned up.

[LOG] Instance Signature: 02c9a2d769dc3ae5efb942ad16578eee45a6f6dd_1708443832
[LOG] Hyprland PID: 977
[LOG] ===== SYSTEM INFO: =====
[LOG] System name: Linux
[LOG] Node name: mach
[LOG] Release: 6.7.5-zen1-1-zen
[LOG] Version: #1 ZEN SMP PREEMPT_DYNAMIC Sat, 17 Feb 2024 14:02:21 +0000

[LOG] GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-U GT2 [UHD Graphics] [8086:9b41] (rev 02) (prog-if 00 [VGA controller])

[LOG] os-release:
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

[LOG] ========================

[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/

[LOG]
Current splash: Never gonna let you down (I am trying!)

[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] [hookSystem] New hook event registered: configReloaded
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 53.64µs. Estimated average calc time: 0.08µs.
[LOG] Creating the ConfigManager!
[LOG] NOTE: further logs to stdout / logfile are disabled by default. Use debug:disable_logs and debug:enable_stdout_logs to override this.
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 35.12µs. Estimated average calc time: 0.08µs.
[LOG] Using config: /home/niksingh710/.config/hypr/hyprland.conf
vaxerski commented 7 months ago

I see reading the third-to-last line of the log is difficult.

niksingh710 commented 7 months ago

I see reading the third-to-last line of the log is difficult.

Sarcasm ?.... Only this much was in logs ....

alba4k commented 7 months ago

@niksingh710 enable those options in your config, then post the log you get here

niksingh710 commented 7 months ago

@niksingh710 enable those options in your config, then post the log you get here

Logs

aaaah i literaly thought till date that logs are enabled by default 💢

vaxerski commented 7 months ago

image

this is the source most likely, if you don't have tearing enabled explicitly then this signifies a driver issue I believe. I don't think these should fail.

niksingh710 commented 7 months ago

@vaxerski in my observation if monitor is connected and then hyprland is launched the it's ok just glitches are there. but if i disconnect monitor and then reconnect it to running hyprland instance everything freezes. and then reboot is the only option.

alba4k commented 7 months ago

I experienced this too

when disconnecting my laptop from the external monitors, I have to use REISUB

niksingh710 commented 7 months ago

Could be totally unrelated. But earlier when I used to reboot my system was kept on ondemand but now when I reboot it is on schedutil

alba4k commented 6 months ago

@vaxerski I'm fairly sure this should be reopened.

OBS Screen Recordings are fine now, sure, but I still do fairly often see weird graphical glitches appear on screen, usually after opening an app using rofi, before its window appears, or randomly on a monitor after flameshot closes, stuff like that. Looks like the exact same thing this issue was opened for

It is hard to record, as they are usually present for a very short time. But those glitches usually consist in some formation of randomly placed randomly colored pixels in a selected area (usually rectangles, about ~40% of pixels appear glitched)

I highly doubt that all of our gpu drivers decided do die all of a sudden, especially since the glitches seem to appear in specific situations.

alba4k commented 6 months ago

Managed to replicate it pretty consistently.

https://quickshare.samsungcloud.com/bRdRajgOMG1E

This is what this issue looks like, most of the time (similar glitches sometimes appear in smaller parts of the screen). It shows part of the window that was previously open, even though it might not even exist anymore. Also, as can be seen from this video, the opening time of firefox is a lot longer when the glitch appears (it should always be nearly instantaneous).

Here are some better videos (screen recordings, instead of recorded using a phone):

https://github.com/hyprwm/Hyprland/assets/84153269/10d256f5-774f-4e15-aa39-83181726901b

Uncompressed video, yeah, its imgur, sorry

vaxerski commented 6 months ago

is this nvidia

alba4k commented 6 months ago

Nope, intel

vaxerski commented 6 months ago

open a different issue then, as this one is fixed.

alba4k commented 6 months ago

I guess the original issue was never fixed then, as @niksingh710 isn't using nvidia either.

But sure, I can open a different one

vaxerski commented 6 months ago

this issue has been fixed.

Fxzzi commented 6 months ago

I guess the original issue was never fixed then

I tried with both AMD and Nvidia, vaxrys' fixes fixed it on both

alba4k commented 6 months ago

https://github.com/hyprwm/Hyprland/issues/4804