monitoraddedv2 does not return the full name

herrwusel commented 6 months ago

Hyprland Version

System/Version info

```sh Hyprland, built from branch main at commit d6f1b151b2fe85ffbb131cbdd05acefc6a357e81 dirty (animations: fix m_Goal not being set after 4911 (4992)). Date: Wed Mar 6 11:14:13 2024 Tag: v0.36.0-60-gd6f1b151 flags: (if any) System Information: System name: Linux Node name: framework Release: 6.7.8-arch1-1 Version: #1 SMP PREEMPT_DYNAMIC Sun, 03 Mar 2024 00:30:36 +0000 GPU information: c1:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c4) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Bug or Regression?

Bug

Description

I already asked this in the PR, but want to document this as an issue as well. Please correct me, if I'm wrong.

If understand this PR correctly, a monitoraddedv2 event is added that contains more information about plugged in monitor. With monitoraddedv2 I only get the shortened make. I don't know if that's intended. According to

 szShortDescription =
        removeBeginEndSpacesTabs(std::format("{} {} {}", output->make ? output->make : "", output->model ? output->model : "", output->serial ? output->serial : ""));

it should have more information than just LG, no?

Here is the relevant hyprctl output:

,{
    "id": 1,
    "name": "DP-2",
    "description": "LG Electronics LG ULTRAFINE 308MASX9J302",
    "make": "LG Electronics",
    "model": "LG ULTRAFINE",
    "serial": "308MASX9J302",
    "width": 3840,
    "height": 2160,
    "refreshRate": 60.00000,
    "x": 1928,
    "y": 0,
    "activeWorkspace": {
        "id": 3,
        "name": "3"
    },
    "specialWorkspace": {
        "id": 0,
        "name": ""
    },
    "reserved": [0, 31, 0, 0],
    "scale": 1.67,
    "transform": 0,
    "focused": true,
    "dpmsStatus": true,
    "vrr": false,
    "activelyTearing": false
}]

How to reproduce

Observe the socket and plug in a monitor.

Crash reports, logs, images, videos

No response

vaxerski commented 6 months ago

can you post the output of the socket?

herrwusel commented 6 months ago

I forget to copy it over from the PR: monitoraddedv2>>1,DP-2,LG

hyprwm / Hyprland