hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.
https://hyprland.org
BSD 3-Clause "New" or "Revised" License
19.41k stars 811 forks source link

Weird flickering when opening and closing windows #5624

Open joelmathewthomas opened 4 months ago

joelmathewthomas commented 4 months ago

Hyprland Version

System/Version info ```sh Hyprland, built from branch main at commit e57a2d7ec87ae775828ea8628ef4eeafce8e6e70 (keybindmgr: add optional `silent` suffix to `movewindow`. (5597)). Date: Wed Apr 17 16:34:16 2024 Tag: v0.39.1-2-ge57a2d7e, commits: 4462 flags: (if any) System Information: System name: Linux Node name: nitro5 Release: 6.8.4-arch1-1 Version: #1 SMP PREEMPT_DYNAMIC Fri, 05 Apr 2024 00:14:23 +0000 GPU information: 0000:00:02.0 VGA compatible controller [0300]: Intel Corporation TigerLake-H GT1 [UHD Graphics] [8086:9a60] (rev 01) (prog-if 00 [VGA controller]) 0000:01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA107M [GeForce RTX 3050 Ti Mobile] [10de:25a0] (rev a1) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Bug or Regression?

Bug

Description

There is a weird flicker when opening a window or closing a window. Watch this screenrecording Video I tried to bisect the issue, but couldn't do it , as i went back as far as commit , a2a29a60e5301df2cadf58c1bb18495d02710547 and the issue was still there.

How to reproduce

Install Hyprland on a system with intel-igpu

Crash reports, logs, images, videos

No response

vaxerski commented 4 months ago

where flicker?

joelmathewthomas commented 4 months ago

where flicker?

it is easily noticeable , when seen in person. pls watch by downloading the video, as other wise the low bitrate of drive opening it, may cause it not to be visible.

Watch this video. Please download it and watch. This time i've added a black background . Towards the end of the video, you'll see more clearly that closing a window has a small delay before the faded window is gone from the view completely. This appears as a flicker.

vaxerski commented 4 months ago

thats odd...

joelmathewthomas commented 4 months ago

thats odd...

Yes.

The-Briel-Deal commented 4 months ago

I really am not able to see a flicker either? When you say flicker do you mean it gets a little bit darker or lighter on the screen briefly would be curious to hear what monitor you have or what kind of screen is on your laptop? With some monitors like oleds the brightness will change when a bunch of dark windows come onto the screen as they have a peak brightness.

I'm not able to replicate this running on my laptop with an intel igpu or nvidia mobile gpu.

joelmathewthomas commented 4 months ago

I really am not able to see a flicker either? When you say flicker do you mean it gets a little bit darker or lighter on the screen briefly would be curious to hear what monitor you have or what kind of screen is on your laptop? With some monitors like oleds the brightness will change when a bunch of dark windows come onto the screen as they have a peak brightness.

I'm not able to replicate this running on my laptop with an intel igpu or nvidia mobile gpu.

You should watch the second video I attached. Download it, else low bitrate will not let you see it.

When I close a window, the animation plays out, but still there is a small delay for the window to completely fade out, and when it does, it does it with no animation, that it appears like a flicker .

Also my laptop has an lcd screen.

joelmathewthomas commented 4 months ago

I really am not able to see a flicker either? When you say flicker do you mean it gets a little bit darker or lighter on the screen briefly would be curious to hear what monitor you have or what kind of screen is on your laptop? With some monitors like oleds the brightness will change when a bunch of dark windows come onto the screen as they have a peak brightness.

I'm not able to replicate this running on my laptop with an intel igpu or nvidia mobile gpu.

You should watch the second video I attached. Download it, else low bitrate will not let you see it.

When I close a window, the animation plays out, but still there is a small delay for the window to completely fade out, and when it does, it does it with no animation, that it appears like a flicker .

Also my laptop has an lcd screen.

Also, I think @vaxerski was able to notice it , as he commented that it was odd . Watch the video

joelmathewthomas commented 4 months ago

@vaxerski @The-Briel-Deal Also i think it's worth mentioning , that this seems to happen for gtk apps, like kitty doesnt have this problem, but thunar , nemo , ,gedit all of them have a problem.

joelmathewthomas commented 4 months ago

@vaxerski @The-Briel-Deal I just tried to delete the .config folder and start a new session . And with a default configured hyprland , there seems to be no problem. Now i am not sure what exactly is causing the problem. Do you have any suggestion on how i can figure out what is causing this issue.

Also , there's another weird thing i found.

https://github.com/hyprwm/Hyprland/assets/90510078/110c6b1d-456f-408a-be32-e18cbbe413f6

joelmathewthomas commented 4 months ago

@vaxerski @The-Briel-Deal Also i think it's worth mentioning , that this seems to happen for gtk apps, like kitty doesnt have this problem, but thunar , nemo , ,gedit all of them have a problem.

I think i know why this affects only gtk apps.

I switched the gtk theme from nordic to default Raleigh theme using nwg-look. And it's better. I wouldn't say it's gone , but it's definitely less noticeable.

Also this happens on amd aswell,.I just couldn't see it easily due to small screen.

The-Briel-Deal commented 4 months ago

After watching a bit I can see the transparent window hang for a minute at the end of the animation. It seems relatively benign but I would guess that its due to an issue with your means of closing of the window. It seems like when you close the window that it takes a bit longer window to fully close probably due to the window doing some cleanup on shutdown. You could probably just make the window transparent after closing if it bothers you.

I wouldn't mind looking into this but I really cannot replicate it even with GTK apps unfortunately. Does it happen with the default config? I wonder if it could be your config specifically.

joelmathewthomas commented 4 months ago

After watching a bit I can see the transparent window hang for a minute at the end of the animation. It seems relatively benign but I would guess that its due to an issue with your means of closing of the window. It seems like when you close the window that it takes a bit longer window to fully close probably due to the window doing some cleanup on shutdown. You could probably just make the window transparent after closing if it bothers you.

I wouldn't mind looking into this but I really cannot replicate it even with GTK apps unfortunately. Does it happen with the default config? I wonder if it could be your config specifically.

With the default config , it doesn't occur, it only happens when I change gtk theme to anything other than the default.

The-Briel-Deal commented 4 months ago

Any chance you can share your config?

joelmathewthomas commented 4 months ago

Any chance you can share your config?

Definitely. https://github.com/joelmathewthomas/nitro5-dots

Try comit 8914e725b3fcf55268289408453e59e6f4df86ce

https://github.com/joelmathewthomas/nitro5-dots/commit/8914e725b3fcf55268289408453e59e6f4df86ce