follow_mouse=2 unusable in latest git

krims0n32 commented 5 months ago

Hyprland Version

System/Version info

```sh Hyprland, built from branch makepkg at commit 94c20a186372aace78b188842848b873eb3ebbd7 (primary-selection: move to hyprland impl). Date: Wed May 15 00:13:35 2024 Tag: v0.40.0-87-g94c20a18, commits: 4693 flags: (if any) System Information: System name: Linux Node name: nyx Release: 6.8.9-arch1-1 Version: #1 SMP PREEMPT_DYNAMIC Thu, 02 May 2024 17:49:46 +0000 GPU information: 03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 31 [Radeon RX 7900 XT/7900 XTX/7900M] [1002:744c] (rev c8) (prog-if 00 [VGA controller]) 19:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Raphael [1002:164e] (rev c9) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Bug or Regression?

Bug

Description

Using follow_mouse = 2 in my config, focussing windows doesn't work anymore, neither does selecting text. Mouse clicks do not register or register in the wrong spot. Waybar does not seem affected, but every other app is.

This worked fine for me up to 0.40.

follow_mouse = 1 works properly.

How to reproduce

Install latest git, set follow_mouse = 2 in the config, open up some apps and try using the mouse on them, selecting text, scrolling, clicking.

Crash reports, logs, images, videos

No response

mamaraddio commented 5 months ago

Also do I can confirm this behavior with latest git commit.

System/Version info

```sh Hyprland, built from branch makepkg at commit 94c20a186372aace78b188842848b873eb3ebbd7 (primary-selection: move to hyprland impl). Date: Wed May 15 00:13:35 2024 Tag: v0.40.0-87-g94c20a18, commits: 4693 flags: (if any) System Information: System name: Linux Node name: mach Release: 6.8.9-arch1-2 Version: #1 SMP PREEMPT_DYNAMIC Tue, 07 May 2024 21:35:54 +0000 GPU information: 01:00.0 VGA compatible controller [0300]: NVIDIA Corporation TU117M [GeForce GTX 1650 Mobile / Max-Q] [10de:1f91] (rev a1) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Also windowrules are not respected. For example:

my terminal emulator (wezterm) opens in floating window even if I have no windowrules for wezterm
the following keybinding opens firefox in current workspace without fakefullscreen
```
bind = SUPER, M, exec, [workspace 1 silent;fakefullscreen] firefox -p PROFILE
```

vaxerski commented 5 months ago

git bisect please https://wiki.hyprland.org/Crashes-and-Bugs/#bisecting-an-issue

and select "regression" next time

mamaraddio commented 5 months ago

Hi @vaxerski this is the result of git bisect

bisect output

```sh 121d3a72137d4780602cf245704615f63357ea22 is the first bad commit commit 121d3a72137d4780602cf245704615f63357ea22 Author: Vaxry Date: Fri May 10 18:27:57 2024 +0100 wl_seat: move to hyprland impl CMakeLists.txt | 10 + src/Compositor.cpp | 75 ++---- src/Compositor.hpp | 4 - src/desktop/LayerSurface.cpp | 13 +- src/desktop/WLSurface.cpp | 2 - src/events/Devices.cpp | 6 - src/events/Events.hpp | 1 - src/events/Misc.cpp | 24 +- src/events/Windows.cpp | 3 +- src/helpers/WLClasses.hpp | 8 - src/includes.hpp | 1 - src/managers/KeybindManager.cpp | 64 +++-- src/managers/PointerManager.cpp | 5 +- src/managers/ProtocolManager.cpp | 5 + src/managers/SeatManager.cpp | 391 +++++++++++++++++++++++++++++++ src/managers/SeatManager.hpp | 106 +++++++++ src/managers/input/InputManager.cpp | 134 +++++------ src/managers/input/InputManager.hpp | 4 +- src/managers/input/Tablets.cpp | 5 +- src/managers/input/Touch.cpp | 14 +- src/protocols/FocusGrab.cpp | 291 +++++++++++------------ src/protocols/FocusGrab.hpp | 8 +- src/protocols/InputMethodV2.cpp | 12 +- src/protocols/PointerConstraints.cpp | 5 +- src/protocols/PointerGestures.cpp | 52 +++-- src/protocols/RelativePointer.cpp | 8 +- src/protocols/SessionLock.cpp | 3 +- src/protocols/Tablet.cpp | 20 +- src/protocols/core/Seat.cpp | 437 +++++++++++++++++++++++++++++++++++ src/protocols/core/Seat.hpp | 163 +++++++++++++ src/render/Renderer.cpp | 4 +- 31 files changed, 1462 insertions(+), 416 deletions(-) create mode 100644 src/managers/SeatManager.cpp create mode 100644 src/managers/SeatManager.hpp create mode 100644 src/protocols/core/Seat.cpp create mode 100644 src/protocols/core/Seat.hpp ```

Maybe this is unrelated but I also noticed that with the latest git commit also the build/install_manifest.txt file was not created leading to impossibility to run sudo make uninstall

krims0n32 commented 5 months ago

Hi @vaxerski this is the result of git bisect

Thanks, beat me to it.

vaxerski commented 5 months ago

enjoy

hyprwm / Hyprland