Clipboard synchronization between wayland and xwayland clients broken

[Ghosthree3]

Hyprland Version

System/Version info

```sh Hyprland, built from branch main at commit 2ead1fd22103ce065661555513bace5897083ded (virtual-keyboard: emit event before finishing keyboard). Date: Sat May 18 05:07:33 2024 Tag: v0.40.0-111-g2ead1fd2, commits: 4717 flags: (if any) System Information: System name: Linux Node name: milkbar Release: 6.9.1-arch1-1 Version: #1 SMP PREEMPT_DYNAMIC Fri, 17 May 2024 16:56:38 +0000 GPU information: 0b:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT] [1002:731f] (rev c1) (prog-if 00 [VGA controller]) 0c:00.0 VGA compatible controller [0300]: NVIDIA Corporation TU104 [GeForce RTX 2070 SUPER] [10de:1e84] (rev a1) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Bug or Regression?

Regression

Description

Trying to copy/paste data between wayland and xwayland clients is broken as of 121d3a7.

121d3a72137d4780602cf245704615f63357ea22 is the first bad commit

An error can be observed from xwayland clients when trying to paste something copied from a wayland client if the xwayland clipboard is empty.

[glfw error 65545]: X11: Failed to convert selection to data from clipboard

But if there exists something on the xwayland clipboard (because of a copy from an existing xwayland client) that will be pasted and no error given. When pasting into a wayland client, the last copy from a wayland client is used (if it still exists), regardless of the existence of a valid xwayland clipboard or not.

There was one time when playing around copying and pasting I managed to crash Hyprland. I think while attempting to close an xwayland window with something on its clipboard, which would hang invisibly.

How to reproduce

Open two windows, one under wayland, one under xwayland, and try to copy paste between them.

I was testing by opening a terminal (kitty) under wayland, then using it to load an x11 copy of itself (kitty -o linux_display_server=x11) and trying to copy paste between them.

First noticed because I was unable to copy paste things from my browser into Discord.

Crash reports, logs, images, videos

No response

[ding444]

Can confirm. I cannot copy/paste between Firefox and electron apps like Discord, Steam, and Obsidian.

System info

``` Hyprland, built from branch main at commit a8522db683ae260f16f8e7778561d8a54906beb1 (keybinds: fix empty on monitor for new workspaces (6089)). Date: Wed May 15 13:03:51 2024 Tag: v0.40.0-93-ga8522db6, commits: 4699 flags: (if any) System name: Linux Node name: endeavour Release: 6.9.1-arch1-1 Version: #1 SMP PREEMPT_DYNAMIC Fri, 17 May 2024 16:56:38 +0000 GPU information: 01:00.0 VGA compatible controller [0300]: NVIDIA Corporation AD102 [GeForce RTX 4090] [10de:2684] (rev a1) (prog-if 00 [VGA controller]) os-release: NAME="EndeavourOS" PRETTY_NAME="EndeavourOS" ID="endeavouros" ID_LIKE="arch" BUILD_ID="2024.01.25" ANSI_COLOR="38;2;23;147;209" HOME_URL="https://endeavouros.com" DOCUMENTATION_URL="https://discovery.endeavouros.com" SUPPORT_URL="https://forum.endeavouros.com" BUG_REPORT_URL="https://forum.endeavouros.com/c/general-system/endeavouros-installation" PRIVACY_POLICY_URL="https://endeavouros.com/privacy-policy-2" LOGO="endeavouros" ```

[NEUKhoaLe]

I think Varxy mentioned that Copy/Paste will be broken until the xwayland rewrite is completed.

https://github.com/hyprwm/Hyprland/pull/6086

[Ghosthree3]

I suppose this can be closed if he wants in that case, since it's a planned issue.

[vaxerski]

we can keep it to avoid dupes, I'll just link 6086 to this

[The-Briel-Deal]

Things seem to work for me with XClip? https://github.com/astrand/xclip

Try using this as a workaround for now.

[RandomLegend]

@The-Briel-Deal

Would i have to change the keybindings for copy & paste then aswell? And does XClip work with wayland applications?

[Elbtalkessel]

Little script I'm using for syncing clipboard as workaround

#!/usr/bin/env sh
# Two-way clipboard syncronization between Wayland and X11.
# Requires: wl-clipboard, xclip, clipnotify.
#
# Usage:
#   clipsync.sh watch - run in background.
#   clipsync.sh kill - kill all background processes.
#   echo -n any | clipsync.sh insert - insert clipboard content fron stdin.
#
# Workaround for issue:
# "Clipboard synchronization between wayland and xwayland clients broken"
# https://github.com/hyprwm/Hyprland/issues/6132

# Updates clipboard content of both Wayland and X11 if current clipboard content differs.
# Usage: echo -e "1\n2" | clipsync insert
insert() {
  # Read all the piped input into variable.
  value=$(cat)
  wValue="$(wl-paste)"
  xValue="$(xclip -o -selection clipboard)"

  notify() {
    notify-send -u low -c clipboard "$1" "$value"
  }

  if [ "$value" != "$wValue" ]; then
    notify "Wayland"
    echo -n "$value" | wl-copy
  fi

  if [ "$value" != "$xValue" ]; then
    notify "X11"
    echo -n "$value" | xclip -selection clipboard
  fi
}

watch() {
  # Wayland -> X11
  wl-paste --type text --watch clipsync insert &

  # X11 -> Wayland
  while clipnotify; do
    xclip -o -selection clipboard | clipsync insert
  done &
}

kill() {
  pkill wl-paste
  pkill clipnotify
  pkill xclip
  pkill clipsync
}

"$@"

[Ghosthree3]

I have simply built and am sitting on the commit before the rewrites (4cdddcf) until the xwayland rewrite is merged.

[kaixenberg]

Sorry for the dumb question, but how do I clone the repo b4 the commits?

[Ghosthree3]

Sorry for the dumb question, but how do I clone the repo b4 the commits?

git clone --recursive https://github.com/hyprwm/Hyprland
cd Hyprland
git checkout 4cdddcf
git submodule update
make all
sudo make install

When this is resolved and you want to go back to using your regular installation method (I assume AUR -git), just run sudo make uninstall from within the git directory.

[kaixenberg]

@Ghosthree3 Thanks. Had figured it out already by searching the web ;-) . Thanks for the idea nd everyone for this grt project

[jfvillablanca]

does anyone know how to pin the commit for nix flake inputs? i tried this (with submodules=1 based on #5891)

    hyprland = {
      url = "git+https://github.com/hyprwm/Hyprland/?ref=refs/heads/main&rev=4cdddcfe466cb21db81af0ac39e51cc15f574da9&submodules=1";
    };

but it fails

error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 4933 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/wolfpld/tracy' into submodule path '/tmp/nix-111478-0/subprojects/tracy' failed
Failed to clone 'subprojects/tracy'. Retry scheduled
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 1877 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/canihavesomecoffee/udis86' into submodule path '/tmp/nix-111478-0/subprojects/udis86' failed
Failed to clone 'subprojects/udis86'. Retry scheduled
error: 85 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/wolfpld/tracy' into submodule path '/tmp/nix-111478-0/subprojects/tracy' failed
Failed to clone 'subprojects/tracy' a second time, aborting

UPDATE: here's what worked for me

    hyprland = {
      type = "git";
      url = "https://github.com/hyprwm/Hyprland";
      submodules = true;
      rev = "4cdddcfe466cb21db81af0ac39e51cc15f574da9";
    };

it was able to build (with some errors which, i believe, is due to submodules = true)

error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 2422 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/hyprwm/wlroots-hyprland' into submodule path '/tmp/nix-143604-0/subprojects/wlroots-hyprland' failed
Failed to clone 'subprojects/wlroots-hyprland'. Retry scheduled
warning: updating lock file '/home/jfvillablanca/nixos-dot/flake.lock':
• Updated input 'hyprland':
    'git+https://github.com/hyprwm/Hyprland/?ref=refs/heads/main&rev=4cdddcfe466cb21db81af0ac39e51cc15f574da9' (2024-05-14)
  → 'git+https://github.com/hyprwm/Hyprland?ref=refs/heads/main&rev=4cdddcfe466cb21db81af0ac39e51cc15f574da9' (2024-05-14)

[navidmafi]

@jfvillablanca that looks like an unreliable internet connection. git clone is not resilient to connection resets.

error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8) error: 4933 bytes of body are still expected fetch-pack: unexpected disconnect while reading sideband packet fatal: early EOF

[andriandreo]

I'm not precisely an expert here, but just in case this is useful for somebody:

As a researcher, when I need further compatibility with MS Office, I use WPS Office and this issue was bothering me for quite a while. I found the forked script and I modified it a little bit so it's completely functional (I'm not sure why I was getting lots of new line characters when copy-pasting with the original):

https://gist.github.com/andriandreo/cc48e2d67c389919e18c54429d768c1f

[Tristan971]

The issue is closed, but as far as I can tell the issue is still there in 0.41.0. Should I open a new issue?

[Agent00Ming]

there already is an issue open #6247 concerning a specific subset of xwayland applications

[Nama]

This is happening to me since v0.41.0 ._.

[armenr]

Commits to master on hyprland-git haven't helped in my case, but I'll tell you what HAS helped.

A slightly modified version of @Elbtalkessel 's little sync script.

gist: https://gist.github.com/armenr/81b77587c1dda1d00d1c1c9541dcda94

I took the liberty of adding:

• Minor modifications/fixes to prevent the script from throwing errors like: Error: target STRING not available
• Minor modification/fix with the kill command --> renamed to stop
• Option(s) to run with-notifications or without-notifications
• For hyprland users, it also checks for cliphist and syncs cliphist too
• help function, because why not?

Script below:

#!/usr/bin/env sh
#
# Two-way clipboard syncronization between Wayland and X11, with cliphy support!
# !! Recommended use: Drop this file off @ /usr/local/bin/clipsync && make it executable
# Requires: wl-clipboard, xclip, clipnotify.
# Modified from: https://github.com/hyprwm/Hyprland/issues/6132#issuecomment-2127153823
#
# Usage:
#   clipsync watch [with-notifications|without-notifications] - run in background.
#   clipsync stop - kill all background processes.
#   echo -n any | clipsync insert [with-notifications|without-notifications] - insert clipboard content from stdin.
#   clipsync help - display help information.
#
# Workaround for issue:
# "Clipboard synchronization between wayland and xwayland clients broken"
# https://github.com/hyprwm/Hyprland/issues/6132
#
# Also pertains to:
# https://github.com/hyprwm/Hyprland/issues/6247
# https://github.com/hyprwm/Hyprland/issues/6443
# https://github.com/hyprwm/Hyprland/issues/6148

# Updates clipboard content of both Wayland and X11 if current clipboard content differs.
# Usage: echo -e "1\n2" | clipsync insert [with-notifications|without-notifications]
insert() {
  # Read all the piped input into variable.
  value=$(cat)
  wValue=$(wl-paste -n 2>/dev/null || echo "")
  xValue=$(xclip -o -selection clipboard 2>/dev/null || echo "")

  notify() {
    if [ "$1" != "without-notifications" ]; then
      notify-send -u low -c clipboard "$2" "$value"
    fi
  }

  if [ "$value" != "$wValue" ]; then
    notify "$1" "Wayland"
    echo -n "$value" | wl-copy
    # Add to cliphist if it's installed
    if command -v cliphist >/dev/null 2>&1; then
      echo -n "$value" | cliphist store
    fi
  fi

  if [ "$value" != "$xValue" ]; then
    notify "$1" "X11"
    echo -n "$value" | xclip -selection clipboard
    # Add to cliphist if it's installed
    if command -v cliphist >/dev/null 2>&1; then
      echo -n "$value" | cliphist store
    fi
  fi
}

# Watch for clipboard changes and synchronize between Wayland and X11
# Usage: clipsync watch [with-notifications|without-notifications]
watch() {
  # Add a small delay to ensure clipboard services are initialized
  sleep 1

  notification_mode=${1:-with-notifications}

  # Wayland -> X11
  wl-paste --type text --watch bash -c "clipsync insert $notification_mode" &

  # X11 -> Wayland
  while clipnotify; do
    xclip -o -selection clipboard 2>/dev/null | clipsync insert "$notification_mode"
  done &
}

# Kill all background processes related to clipsync
stop_clipsync() {
  pkill -f "wl-paste --type text --watch"
  pkill clipnotify
  pkill -f "xclip -selection clipboard"
  pkill -f "clipsync insert"
}

help() {
  cat << EOF
clipsync - Two-way clipboard synchronization between Wayland and X11, with cliphist support

Usage:
  clipsync watch [with-notifications|without-notifications]
    Run clipboard synchronization in the background.
    Options:
      with-notifications (default): Show desktop notifications for clipboard changes.
      without-notifications: Operate silently without notifications.

  clipsync stop
    Stop all background processes related to clipsync.

  echo -n "text" | clipsync insert [with-notifications|without-notifications]
    Insert clipboard content from stdin.
    Notification options work the same as in the watch command.

  clipsync help
    Display this help information.

Requirements: wl-clipboard, xclip, clipnotify
Optional: cliphist (for Hyprland users)
EOF
}

case "$1" in
  watch)
    watch "$2"
    ;;
  stop)
    stop_clipsync
    ;;
  insert)
    insert "$2"
    ;;
  help)
    help
    ;;
  *)
    echo "Usage: $0 {watch [with-notifications|without-notifications]|stop|insert [with-notifications|without-notifications]|help}"
    echo "Run '$0 help' for more information."
    exit 1
    ;;
esac

...And now, 1Password is usable again 🚀

[vadim-su]

Fix doesn't work for me