Implement xdg-foreign v1 & v2 protocols

DerpDays commented 1 month ago

Description

It would be nice the xdg-foreign protocol was supported.

It can be used when binding global shortcuts to the xdg desktop portal (which i'm assuming would allow for the shortcuts to be unbound when the surface they are binded to is destroyed - not sure about this though). Without the protocol we can only pass an empty string when binding global shortcuts.

Doesn't affect the ability to bind global shortcuts since we can just pass an empty string, so it's just something nice to have.

I'm also not sure how to properly set the shortcut app name since when I create a shortcut with an id, to bind the keybind in hyprland I have to use :id instead of app:id as described in the wiki, so I'm assuming the app id is most likely meant to be related to surface that bound the global keybinds (which I can only set to an empty string) from it's corresponding layer namespace or app id - please correct me if I'm wrong though.

vaxerski commented 1 month ago

app can be any string, it's just used for easier identification by the user and avoiding collisions.

DerpDays commented 1 month ago

Does the appid come from the options passed when creating the session then or is it somewhere else I've missed? I've taken a look at xdph but since I'm unfamiliar with c++ I'm unsure how the appid is extracted from sdbus::MethodCall.

vaxerski commented 1 month ago

if XDPH is registering, it comes from here: https://github.com/hyprwm/xdg-desktop-portal-hyprland/blob/b9b97e5ba23fe7bd5fa4df54696102e8aa863cf6/src/portals/GlobalShortcuts.cpp#L41-L42

hyprwm / Hyprland

Implement xdg-foreign v1 & v2 protocols #6884

Description