hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.
https://hyprland.org
BSD 3-Clause "New" or "Revised" License
21.7k stars 900 forks source link

Overlay from hyprland-protocols breaks lots of package in NixOS #7930

Closed L-Trump closed 1 month ago

L-Trump commented 1 month ago

Already reported ? *

Regression?

Yes

System Info and Version

Not important

Description

The commit https://github.com/hyprwm/Hyprland/commit/14942bca60cc7d85e8238a151bd444112601ebe6 introduces the hyprland-protocols to the flake of Hyprland, including its overlay. However, the overlay in hyprland-protocols includes a version package. This breaks lots of nixos packages like lxqt.libqtxdg, since these packages have an argument called version. See below:

https://github.com/hyprwm/hyprland-protocols/blob/5a11232266bf1a1f5952d5b179c3f4b2facaaa84/flake.nix#L30C1-L36C7

    overlays = {
      hyprland-protocols = final: prev: {
        hyprland-protocols = final.callPackage ./nix/default.nix {inherit version;};
        version = version + "+date=" + (mkDate (self.lastModifiedDate or "19700101")) + "_" + (self.shortRev or "dirty");
      };
      default = self.overlays.hyprland-protocols;
    };

How to reproduce

Build NixOS with Hyprland overlay and package lxqt.lxqt-policykit.

Crash reports, logs, images, videos

No response

vaxerski commented 1 month ago

@fufexan

fufexan commented 1 month ago

Wow... what was I smoking back then. Fixed in 58669fef and hyprwm/hyprland-protocols@6b3261e.