`size` not respected if workspace unfocused

hyprwm / Hyprland

Hyprland is an independent, highly customizable, dynamic tiling Wayland compositor that doesn't sacrifice on its looks.

https://hyprland.org

BSD 3-Clause "New" or "Revised" License

21.96k stars 912 forks source link

`size` not respected if workspace unfocused #904

Closed ghost closed 2 years ago

ghost commented 2 years ago

Simple one to reproduce.

Ensure the following rules class referenced as x x opens silently on workspace 9. windowrulev2=workspace 9 silent,class:^(x)$ x has size rule. windowrulev2=size 700 350,class:^(x)$ x is floating. windowrulev2=float,class:^(x)$
Window will not respect rules if the target workspace is not focused.

As shown in the video below. https://streamable.com/ctjlrf

ghost commented 2 years ago

s/opens on/opens silently on/

ghost commented 2 years ago

e4527c6 was supposed to fix this bug, I previously had this problem. You can also see additional information at https://discord.com/channels/961691461554950145/961694014615208048/1024685093312270356

vaxerski commented 2 years ago

fixed in 1d0d350fc31c7b7b834dcf15016bf1495b81d7e1

ghost commented 2 years ago

I have tested it, Now nofocus windows don't seem to listen to workspace x silent. As shown in the video below. https://streamable.com/baj2e4

ghost commented 2 years ago

https://streamable.com/vatpoi here is a better video

ghost commented 2 years ago

cf869d9 https://streamable.com/8k1iha

ghost commented 2 years ago

@vaxerski

vaxerski commented 2 years ago

stop pinging me ffs. It works for me, maybe you didn't update. check hyprctl version

ghost commented 2 years ago

I did update that's why I shown you cf869d9.

I might be dumb, I'm not that dumb lmao

vaxerski commented 2 years ago

check hyprctl version

ghost commented 2 years ago

https://imgur.com/a/FTMT7RF

vaxerski commented 2 years ago

you can paste images here. Imgur is over capacity.

ghost commented 2 years ago

I have no idea how you managed to fck it up this badly. Lol. https://streamable.com/pnyaql

ghost commented 2 years ago

Steam (in gamescope) is now launching in workspace 9 (where mpd stuff is supposed to be) even tho it has rules (https://gitlab.com/rscotty-rice/dotfiles/-/blob/main/home/rscott/.config/hypr/steam.conf)

vaxerski commented 2 years ago

no clue what is happening in the video. 0 explanations, just a random video of you opening stuff. As I've said, it works perfectly fine on my end, and the patch was not enough to introduce any new bugs.

ghost commented 2 years ago

Yeas...

The issue has two videos, before and after this patch, showing that silent was working, it is now not working. And surely you are aware of this...

Would you really want me to prove to you that silent was working before cf869d9? Since you somehow believe I'm talking bollocks or?

ghost commented 2 years ago

Before cf869d9: https://streamable.com/vatpoi After cf869d9: https://streamable.com/8k1iha & on startup: https://streamable.com/pnyaql

vaxerski commented 2 years ago

https://user-images.githubusercontent.com/43317083/197565874-f1909367-5050-4d56-85bc-d6d39c8295d4.mp4

cuz u are talking bollocks

vaxerski commented 2 years ago

Wait are you setting a silent rule to move to a workspace on a different monitor?? That's not allowed, you need to set monitor rule too.

ghost commented 2 years ago

Before https://github.com/hyprwm/Hyprland/commit/cf869d963687d26876f6e203a925cd6648380c4a: https://streamable.com/vatpoi After https://github.com/hyprwm/Hyprland/commit/cf869d963687d26876f6e203a925cd6648380c4a: https://streamable.com/8k1iha & on startup: https://streamable.com/pny

clearly the shit worked be4 and doesn't work now. blaintant autism.

ghost commented 2 years ago

Soz for the language bud but I dont speak bollocks.

vaxerski commented 2 years ago

69f1d7b3607bb088512420052b9e0d48e529772d should fix all your issues and please go outside and touch grass now instead of pestering me

ghost commented 2 years ago

Newest silent patch (69f1d7b), still has issues.

For odd reasons my mpd workspace (9) is bound to my TV (HDMI-A-2), despite having rules (wsbind) to specifically bind workspace 9 to my monitor (HDMI-A-1).

As shown in the video below. https://streamable.com/qtz7o6