hyprwm / aquamarine

Aquamarine is a very light linux rendering backend library
BSD 3-Clause "New" or "Revised" License
219 stars 16 forks source link

Remove redundant needsFrame & allow frame schedule skipping on mouse move #21

Closed UjinT34 closed 1 month ago

UjinT34 commented 1 month ago

skipShedule requires HL updates to be useful. Just passing true to moveCursor is not enough to fix VRR. Probably needs something like https://github.com/hyprwm/Hyprland/pull/6877 for hw cursors.

UjinT34 commented 1 month ago

It is not guaranteed that the cursor position will be updated to the correct value when something finally decides that the frame should be rendered. Something needs to update the cursor position between frames without triggering extra frames. I think it's easier to skip frame schedule than to call an extra moveCursor under complex conditions. Not moving the cursor will definitely solve the VRR issues but that's not what humans want. They can't keep their hands off the mouse and tend to get disappointed when their cursor is stuck in place %)

vaxerski commented 1 month ago

ok