search

hyprwm / contrib

Community scripts and utilities for Hypr projects
MIT License
284 stars 39 forks source link

hdrop: 0.1.3 -> 0.2.1, Update readme #73

Closed Schweber closed 10 months ago

Schweber commented 10 months ago

Ok, i added it and reduced the help text. I have a question:

On nixpkgs, grimblast has got

  strictDeps = true;

  nativeBuildInputs = [
    makeWrapper
    scdoc
  ];

On hyprwm/contrib it has got

  nativeBuildInputs = [
    makeWrapper
  ];

  buildInputs = [
    scdoc
  ];

What's the difference / which one is better and why?

fufexan commented 10 months ago

I think the one in Nixpkgs is idiomatic, as nativeBuildInputs are dependencies which are needed for compilation/package building. buildInputs are generally runtime dependencies. I'll do a refactor sometime.

Schweber commented 10 months ago

I see, thanks. Is strictDeps = true; beneficial or can it be left out?

fufexan commented 10 months ago

Ok, looks good. Only one more thing, can you rename the commits in the style hdrop: <action>? Unless you want me to squash them.

Schweber commented 10 months ago

Please squash them, I'll do it correctly the next time.

If i now start doing force pushes or something like that i'll screw it up because i'm just learning Github etc.

fufexan commented 10 months ago

I've rebased the commits and squashed a few. Looks good?

Schweber commented 10 months ago

To be honest, i don't understand that part yet. But if you're satisfied, then so am i ;)