hyprwm / hyprland-plugins

Official plugins for Hyprland
BSD 3-Clause "New" or "Revised" License
521 stars 53 forks source link

[Request] Make xwayland as optional for hyprbars. #122

Closed lidgnulinux closed 6 months ago

lidgnulinux commented 6 months ago

Hello, it seems hyprbars can't be built if I build Hyprland without Xwayland in the first place. Is it common ? Thanks.

I got this :

[hyprbars]$ C_INCLUDE_PATH=/usr/local/include/ PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ LD_LIBRARY_PATH=/usr/local/lib/ ninja -C build/
ninja: entering directory 'build/'
[1/3] Compiling C++ object libhyprbars.so.p/barDeco.cpp.o
[2/3] Compiling C++ object libhyprbars.so.p/main.cpp.o
ninja: job failed: c++ -Ilibhyprbars.so.p -I. -I.. -I/usr/local/include -I/usr/local/include/hyprland/protocols -I/usr/local/include/hyprland/wlroots -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/libpng16 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -Wno-narrowing -std=c++23 -fPIC -pthread -MD -MQ libhyprbars.so.p/barDeco.cpp.o -MF libhyprbars.so.p/barDeco.cpp.o.d -o libhyprbars.so.p/barDeco.cpp.o -c ../barDeco.cpp
In file included from /usr/local/include/hyprland/src/defines.hpp:1,
                 from /usr/local/include/hyprland/src/render/decorations/IHyprWindowDecoration.hpp:4,
                 from ../barDeco.hpp:5,
                 from ../barDeco.cpp:1:
/usr/local/include/hyprland/src/includes.hpp:119:10: fatal error: wlr/xwayland.h: No such file or directory
  119 | #include <wlr/xwayland.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
ninja: job failed: c++ -Ilibhyprbars.so.p -I. -I.. -I/usr/local/include -I/usr/local/include/hyprland/protocols -I/usr/local/include/hyprland/wlroots -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/libpng16 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -Wno-narrowing -std=c++23 -fPIC -pthread -MD -MQ libhyprbars.so.p/main.cpp.o -MF libhyprbars.so.p/main.cpp.o.d -o libhyprbars.so.p/main.cpp.o -c ../main.cpp
In file included from /usr/local/include/hyprland/src/defines.hpp:1,
                 from /usr/local/include/hyprland/src/Compositor.hpp:7,
                 from ../main.cpp:6:
/usr/local/include/hyprland/src/includes.hpp:119:10: fatal error: wlr/xwayland.h: No such file or directory
  119 | #include <wlr/xwayland.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
ninja: subcommands failed

It's just request but I will happy to see it if that gets implemented.

lidgnulinux commented 6 months ago

Solved, thanks... I just need to adjust some headers and all are good.