Hyprbars: Left title align doesn't work

hyprwm / hyprland-plugins

Official plugins for Hyprland

BSD 3-Clause "New" or "Revised" License

521 stars 53 forks source link

Hyprbars: Left title align doesn't work #137

Closed Liassica closed 5 months ago

Liassica commented 5 months ago

When using Hyprbars ~from the flake~, the window title is center-aligned even when bar_text_align is set to left. ~This does not happen when using hyprpm, as far as I can tell.~ Other Hyprbars settings are applied as expected.

Update: https://github.com/hyprwm/hyprland-plugins/issues/137#issuecomment-2060076442.

vaxerski commented 5 months ago

@fufexan wtf?

RoseHobgoblin commented 5 months ago

I'm also receiving issues with the bar color not being as expected Screenshot_04-12-2024_3757 Screenshot_04-12-2024_3851

Liassica commented 5 months ago

@RoseHobgoblin Should be bar_color, not bar_colour, no? :)

RoseHobgoblin commented 5 months ago

@RoseHobgoblin Should be bar_color, not bar_colour, no? :)

teehee britbrain

Liassica commented 5 months ago

For a bit more info on the main issue: this did not used to happen a few months ago but I couldn't tell you exactly when it started happening. I also haven't been able to test recently, but the last time I had Arch + Hyprland + Hyprbars working on my laptop (just under a month ago) hyprpm-installed Hyprbars worked as expected (while at the same time it did not using the flake on my NixOS system).

fufexan commented 5 months ago

Well we aren't patching it in any way.

Liassica commented 5 months ago

After seeing #139 I don't think this issue is unique to the flake. The mismatched behavior I was seeing was likely just due to mismatched Hyprbars/Hyprland versions between my two systems. After poking around in the code a bit I've found two solutions that seem to fix this (keep in mind I am not a programmer):

Using a boolean value similar to how BUTTONSRIGHT is used
Converting *PALIGN to a string before comparing its value (i.e. std::string{*PALIGN} == "left" instead of *PALIGN == "left")

In both instances I am now able to use both left title align and center title align as expected. Other settings such as button alignment seem to continue to work as expected.