search

hyprwm / hyprlang

The official implementation library for the hypr config language.
https://wiki.hyprland.org/Hypr-Ecosystem/hyprlang/
GNU Lesser General Public License v3.0
137 stars 16 forks source link

Fixed getconf command in build instructions #44

Closed pebble-24 closed 5 months ago

pebble-24 commented 5 months ago

getconf NPROCESSORS_CONF isn't a valid command. The correct command is getconf _NPROCESSORS_CONF.

jbeich commented 5 months ago

Please, revert. nproc fallback is originally for compatibility with non-GNU systems. See FreeBSD fix and POSIX fix. NetBSD and OpenBSD still don't support GNU-style with leading underscore.

fufexan commented 5 months ago

@jbeich is switching to the Ninja generator and dropping nproc entirely a suitable solution for BSD?

jbeich commented 5 months ago

Sure. All BSDs package ninja and samurai.

fufexan commented 5 months ago

Right, I've removed those in favor of the Ninja generator, as per this comment.

I can update the READMEs of the rest of the repos to use -G Ninja and add a note for DragonFly users to manually use getconf NPROCESSORS_CONF.

jbeich commented 5 months ago

add a note for DragonFly

Please, don't to avoid cruft in future.