hyprwm / hyprlock

Hyprland's GPU-accelerated screen locking utility
BSD 3-Clause "New" or "Revised" License
718 stars 53 forks source link

Fullscreen Windows Not Covered by Hyprlock #438

Closed Arqamz closed 1 month ago

Arqamz commented 1 month ago

Fullscreen Windows Not Covered by Hyprlock

Description: When a window is in fullscreen mode and Hyprlock is activated, the fullscreen window remains visible instead of Hyprlock overlaying it. This issue is reproducible with applications like VSCode and terminal but did not occur with Chrome for me. This behavior creates a potential security risk, as the contents of the fullscreen window are still visible while Hyprlock is supposedly active.

Steps to Reproduce:

  1. Open an application (e.g., VSCode or terminal) in fullscreen mode on one monitor.
  2. Activate Hyprlock.

Expected Behavior: Hyprlock should overlay and lock the screen, covering all fullscreen applications.

Actual Behavior: The fullscreen application remains visible, although Hyprlock is active on the other monitor that does not have a fullscreen application open.

Attachments:

Arqamz commented 1 month ago

Please try reproducing it on a setup with 2 monitors so you can see the difference. It's not very clear in the video when I press the keybind for hyprlock (I could tell because my other monitor that is not being recorded would have hyprlock launched on it but monitor 1 would still be showing my fullscreen-ed application).

Terminal used: Foot Operating System: NIXOS

vaxerski commented 1 month ago

whats your hyprland version? this has been a bug in very old hl versions

Arqamz commented 1 month ago

I'm on nixpkgs stable. Which the nixpkg website says is on: 0.3.0-unstable-2024-04-24

vaxerski commented 1 month ago

hyprland

Arqamz commented 1 month ago

sorry lol. Also on nixpkgs 24.05 stable. SearchNixos says this is Version 0.41.2

vaxerski commented 1 month ago

hyprctl version

Arqamz commented 1 month ago

image

vaxerski commented 1 month ago

great, I love nix. Both issues you posted (this and #437) are bugs that were present in old hyprland versions. My guess is that you are not on 0.41.2

Arqamz commented 1 month ago

My guess is that you are not on 0.41.2

I just installed and enabled it through pkgs, I'm not sure what version it is but the maintainer/the website says it's version 0.41.2. I'm also pretty sure my hl is the latest aquamarine version, because my env for setting the gpu broke today.

vaxerski commented 1 month ago

that is really odd then. Can't repro. @PaideiaDilemma can't either, right?

PaideiaDilemma commented 1 month ago

no i can't repro. also not with NixOS 24.05's versions of hyprland and hyprlock

PaideiaDilemma commented 1 month ago

I just installed and enabled it through pkgs, I'm not sure what version it is but the maintainer/the website says it's version 0.41.2. I'm also pretty sure my hl is the latest aquamarine version, because my env for setting the gpu broke today.

If you are on LATEST NixOs 24.05, you are on tag 0.41.2, so no aquamarine. Your nixos configuration seems like you build your config with whatever version of nixpkgs you have locally.

Please post output of nixos-version.

fufexan commented 1 month ago

image

There is no way this is from either Nixpkgs or from the flake. They both provide info in hyprctl version. How have you compiled hyprland?

Arqamz commented 1 month ago

It's hardly been a few weeks since I've installed nixos.

nixos-version 24.05.1503.752c634c09ce (Uakari)

nix --version nix (Nix) 2.18.2

You can have a look at my configuration files. Its all really standard I dont use home-manager or flakes my nixos-config

You can look at imports/hypr.nix imports/user.nix imports/system-packages.nix and configuration.nix

PaideiaDilemma commented 1 month ago

According to your nixos-version, you are on hyprland commit f15513309b24790099d42974274eb23f66f7c985 (See here), which is from May 5.

please update your channel and rebuild your config.

PaideiaDilemma commented 1 month ago

Can we close this and #437?

Both of these issues are present in old versions of Hyprland, when it initially switched to it's own implementation of ext-session-lock-v1.