hyprwm / hyprlock

Hyprland's GPU-accelerated screen locking utility
BSD 3-Clause "New" or "Revised" License
840 stars 58 forks source link

Can see a bit of my desktop though hyprlock #461

Closed DHDcc closed 1 month ago

DHDcc commented 3 months ago

Regression?

No

Hyprlock Info and Version

hyprlock v0.4.1-1

Hyprlock config ```sh # GENERAL general { no_fade_in = false grace = 0 disable_loading_bar = false hide_cursor = true ignore_empty_input = true text_trim = true } #BACKGROUND background { monitor = path = $HOME/.config/swww/wallpapers/abstract.png blur_size = 2 blur_passes = 3 # 0 disables blurring contrast = 1.3000 brightness = 0.8000 vibrancy = 0.2100 vibrancy_darkness = 0.0 } # TIME HR label { monitor = text = cmd[update:1000] date +"%H" color = rgba(255, 255, 255, 1) #shadow_pass = 2 shadow_size = 3 shadow_color = rgb(0,0,0) shadow_boost = 1.2 font_size = 200 font_family = AlfaSlabOne position = 0, -270 halign = center valign = top } # TIME label { monitor = text = cmd[update:1000] date +"%M" color = rgba(255, 255, 255, 1) font_size = 200 font_family = AlfaSlabOne position = 0, -500 halign = center valign = top } # DATE label { monitor = text = cmd[update:1000] date +"%d %b %A" color = rgba(255, 255, 255, 1) font_size = 17 font_family = JetBrains Mono Nerd Font Mono ExtraBold position = 10, -115 halign = center valign = center } # LOCATION & WEATHER label { monitor = text = cmd[update:1000] ~/.scripts/weather.sh color = rgba(255, 255, 255, 1) font_size = 17 font_family = JetBrains Mono Nerd Font Mono ExtraBold position = 0, 665 halign = center valign = center } # Music Background #shape { # monitor = # size = 420, 90 # rounding = 10 # border_size = 1 # color = rgba(0,0,0,1) # border_color = rgba(249,249,249,1) # rotate = 0 # shadow_passes = 2 # shadow_size = 4 # position = 20, -309 # halign = center # valign = center # zindex = 0 #} image { monitor = path = size = 75 # lesser side if not 1:1 ratio rounding = 5 # negative values mean circle border_size = 0 rotate = 0 # degrees, counter-clockwise reload_time = 2 reload_cmd = ~/.scripts/playerctlock.sh --arturl position = -195, -365 halign = center valign = center #opacity=0.5 } # PLAYER TITTLE label { monitor = text = cmd[update:0] ~/.scripts/playerctlock.sh --title color = rgba(255, 255, 255, 0.8) font_size = 16 font_family = JetBrains Mono Nerd Font Mono ExtraBold position = 1165, -345 halign = left valign = center } # PLAYER Length label { monitor = text = cmd[update:0] ~/.scripts/playerctlock.sh --duration color = rgba(255, 255, 255, 1) font_size = 14 font_family = JetBrains Mono Nerd Font Mono position = -1020, -370 halign = right valign = center } # PLAYER STATUS label { monitor = text = cmd[update:0] ~/.scripts/playerctlock.sh --status color = rgba(255, 255, 255, 1) font_size = 18 font_family = JetBrains Mono Nerd Font Mono position = -1020, -345 halign = right valign = center } # PLAYER SOURCE label { monitor = text = cmd[update:0] ~/.scripts/playerctlock.sh --source color = rgba(255, 255, 255, 0.6) font_size = 11 font_family = JetBrains Mono Nerd Font Mono position = -1020 -395 halign = right valign = center } # PLAYER Artist label { monitor = text = cmd[update:0] ~/.scripts/playerctlock.sh --artist color = rgba(255, 255, 255, 0.8) font_size = 12 font_family = JetBrains Mono Nerd Font Mono ExtraBold position = 1165, -370 halign = left valign = center } # INPUT FIELD input-field { monitor = size = 350, 75 outline_thickness = 3 outer_color = rgba(0, 0, 0, 1) dots_size = 0.1 # Scale of input-field height, 0.2 - 0.8 dots_spacing = 1 # Scale of dots' absolute size, 0.0 - 1.0 dots_center = true inner_color = rgba(0, 0, 0, 1) font_color = rgba(200, 200, 200, 1) fade_on_empty = false #font_family = JetBrains Mono Nerd Font Mono placeholder_text =  $USER hide_input = false position = 4, -640 halign = center rounding = 10 valign = center zindex = 10 } ```

Compositor Info and Version

System/Version info ```sh Hyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0). Date: Wed Aug 7 19:17:10 2024 Tag: v0.42.0, commits: 5069 flags: (if any) System Information: System name: Linux Node name: ArchBox Release: 6.10.4-arch2-1 Version: #1 SMP PREEMPT_DYNAMIC Sun, 11 Aug 2024 16:19:06 +0000 GPU information: 03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT] [1002:731f] (rev c1) (prog-if 00 [VGA controller]) os-release: NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/" BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=archlinux-logo plugins: ```

Description

When I switch from a 24" to a 27" monitor, I noticed that I could see a bit of my desktop on the right of my monitor when I use hyprlock.

How to reproduce

Use hyprlock on a 27" monitor.

Crash reports, logs, images, videos

swappy-20240815-192811

floork commented 1 month ago

Well I seem to have the same behavior, and it's when the image is too small for the screen (at least for me), when I use an image which is much too small I can see my desktop clearly and without any blur.

DHDcc commented 1 month ago

Well I seem to have the same behavior, and it's when the image is too small for the screen (at least for me), when I use an image which is much too small I can see my desktop clearly and without any blur.

Can it simply stretch the image to fit the monitor size?

floork commented 1 month ago

Well if you only use 1 wallpaper you could add size to the image and scale it up see the wiki, but it would be optimal if hyprlock would implement something that when an image is too small to also have the option to hide the rest in blur, or even better with the color tag over the rest of the screen.

DHDcc commented 1 month ago

Well if you only use 1 wallpaper you could add size to the image and scale it up see the wiki, but it would be optimal if hyprlock would implement something that when an image is too small to also have the option to hide the rest in blur, or even better with the color tag over the rest of the screen.

The size option is only for the image section and not for the background section.

floork commented 1 month ago

Sorry my bad, well as of now I don't really see any way to adjust the size in the lock screen.

AndreasBackx commented 1 month ago

I'm actually getting this even when solely using a black colour, not an image:

background {
    monitor =
    color = rgba(0, 0, 0, 1.0)
}

I have 3 displays in the order portrait, landscape, portrait. On my leftmost one, I can see about 30% of what is "behind" the lock screen still.

Full hyprctl monitors output:

Monitor HDMI-A-1 (ID 1):
    2560x1440@59.95100 at 5168x226
    description: Dell Inc. DELL U2515H 9X2VY6A80A8L
    make: Dell Inc.
    model: DELL U2515H
    serial: 9X2VY6A80A8L
    active workspace: 201 (201)
    special workspace: 0 ()
    reserved: 0 0 0 40
    scale: 1.00
    transform: 3
    focused: no
    dpmsStatus: 1
    vrr: false
    solitary: 0
    activelyTearing: false
    disabled: false
    currentFormat: XRGB8888
    availableModes: 2560x1440@59.95Hz 2048x1152@60.00Hz 1920x1200@59.95Hz 1920x1080@60.00Hz 1920x1080@60.00Hz 1920x1080@59.94Hz 1920x1080@50.00Hz 1920x1080@30.00Hz 1920x1080@29.97Hz 1920x1080@25.00Hz 1920x1080@24.00Hz 1920x1080@23.98Hz 1600x1200@60.00Hz 1680x1050@59.88Hz 1280x1024@75.03Hz 1280x1024@60.02Hz 1440x900@59.95Hz 1200x960@59.99Hz 1280x800@59.95Hz 1152x864@75.00Hz 1280x720@60.00Hz 1280x720@60.00Hz 1280x720@59.94Hz 1280x720@50.00Hz 1024x768@75.03Hz 1024x768@60.00Hz 800x600@75.00Hz 800x600@60.32Hz 720x576@50.00Hz 720x480@60.00Hz 720x480@60.00Hz 720x480@59.94Hz 720x480@59.94Hz 720x480@59.94Hz 640x480@75.00Hz 640x480@60.00Hz 640x480@59.94Hz 640x480@59.94Hz 720x400@70.08Hz

Monitor DP-8 (ID 4):
    3840x2160@59.99700 at 0x0
    description: Dell Inc. DELL U3219Q F2XWXV2
    make: Dell Inc.
    model: DELL U3219Q
    serial: F2XWXV2
    active workspace: 3 (3)
    special workspace: 0 ()
    reserved: 0 0 0 0
    scale: 1.25
    transform: 1
    focused: no
    dpmsStatus: 1
    vrr: false
    solitary: 0
    activelyTearing: false
    disabled: false
    currentFormat: XRGB8888
    availableModes: 3840x2160@60.00Hz 3840x2160@29.98Hz 2560x1440@59.95Hz 2048x1280@59.99Hz 1920x1200@59.88Hz 2048x1080@24.00Hz 1920x1080@60.00Hz 1920x1080@60.00Hz 1920x1080@59.94Hz 1920x1080@50.00Hz 1920x1080@24.00Hz 1920x1080@23.98Hz 1600x1200@60.00Hz 1600x900@60.00Hz 1280x1024@75.03Hz 1280x1024@60.02Hz 1152x864@75.00Hz 1280x720@60.00Hz 1280x720@59.94Hz 1280x720@50.00Hz 1024x768@75.03Hz 1024x768@60.00Hz 800x600@75.00Hz 800x600@60.32Hz 720x576@50.00Hz 720x576@50.00Hz 720x480@60.00Hz 720x480@60.00Hz 720x480@59.94Hz 720x480@59.94Hz 640x480@75.00Hz 640x480@60.00Hz 640x480@59.94Hz 640x480@59.94Hz 720x400@70.08Hz

Monitor DP-1 (ID 2):
    3440x1440@143.92300 at 1728x786
    description: Acer Technologies XV340CK P T5Y000013E00
    make: Acer Technologies
    model: XV340CK P
    serial: T5Y000013E00
    active workspace: 103 (103)
    special workspace: 0 ()
    reserved: 0 0 0 40
    scale: 1.00
    transform: 0
    focused: yes
    dpmsStatus: 1
    vrr: false
    solitary: 0
    activelyTearing: false
    disabled: false
    currentFormat: XRGB8888
    availableModes: 3440x1440@143.92Hz 3440x1440@84.96Hz 3440x1440@120.00Hz 3440x1440@59.97Hz 2560x1440@120.00Hz 2560x1440@59.95Hz 1720x1440@59.98Hz 2048x1152@60.00Hz 1920x1200@59.88Hz 1920x1080@120.00Hz 1920x1080@119.88Hz 1920x1080@119.98Hz 1920x1080@60.00Hz 1920x1080@60.00Hz 1920x1080@59.94Hz 1920x1080@50.00Hz 1600x1200@60.00Hz 1680x1050@59.95Hz 1600x900@60.00Hz 1280x1024@75.03Hz 1280x1024@60.02Hz 1440x900@143.92Hz1280x800@59.81Hz 1152x864@75.00Hz 1280x720@60.00Hz 1280x720@59.94Hz 1024x768@75.03Hz1024x768@70.07Hz 1024x768@60.00Hz 832x624@74.55Hz 800x600@75.00Hz 800x600@72.19Hz 800x600@60.32Hz 800x600@56.25Hz 720x576@50.00Hz 720x480@60.00Hz 720x480@59.94Hz 640x480@75.00Hz 640x480@72.81Hz 640x480@66.67Hz 640x480@60.00Hz 640x480@59.94Hz 640x480@59.94Hz 720x400@70.08Hz
PaideiaDilemma commented 1 month ago

@AndreasBack

Please try the -git version of hyprlock. I think this should be fixed with #456.

AndreasBackx commented 1 month ago

@PaideiaDilemma thank you, I can confirm it is fixed on 0.5.0. Thank you @vaxerski for the release.

AndreasBackx commented 1 month ago

It seems I cheered too soon. The issue still occurs for me, though it was originally fixed. I'm unsure what happened that made it regress so quickly as no changes were made to my config.

Can we reopen the issue?

The versions I have installed are:

image

DHDcc commented 1 month ago

yeah, I still have the same issue.

❯ hyprlock --version
Hyprlock version 0.5.0
❯ pacman -Q hyprlock
hyprlock-git 0.5.0.r0.ga093a9ee-1
PaideiaDilemma commented 1 month ago

Ufff ok @AndreasBackx give me more details. In the screenshots it seems like hyprlock crashed. does that always happens? Any particular steps to reproduce? Monitor configuration? I can see that it is rotated but scaled as well?

AndreasBackx commented 1 month ago

@PaideiaDilemma I'm perhaps misremembering, though I think I was able to login. I cannot reproduce it now and it's largely fixed. My guess is that I have a bad memory and it likely crashed somehow. I've had quite a few crashes so it wouldn't be too uncommon.

I've not reported them because of a lack of time and it was hard distinguishing the logs from the other logs. It would be nice if the logging had some formatting.

Any particular steps to reproduce? Monitor configuration? I can see that it is rotated but scaled as well?

My monitor configuration has been posted in a comment above, it's indeed rotated and scaled. Unfortunately I've been unable to reproduce it since your comment, though it happened a few times before. I'm not sure what triggered it or how I could reproduce it.

Is there anything else I can possibly look out for or share that would help?

If it crashes again, I'll share my logs.

AndreasBackx commented 1 month ago

It was indeed as you said, it was a crash. Here are the logs from everything running on Hyprland, which includes the output of hyprlock as it was called with a keybinding.

https://gist.github.com/AndreasBackx/930be2e3acb6349083815250bb7cdd92

What happened was that around 11:45-11:52 I called hyprlock with no arguments. It lead to the same state as the screenshot above. I didn't respond and because I was leaving for lunch and there was a personal chat visible, I changed tty to the one of GDM. (I know people could still switch it back, but it was also not responding so they likely wouldn't be able to get in.) When I came back to my desk just now, about 30 minutes later, I switched the tty back and it seemed like it had crashed entirely because I was prompted for the usual login.

Let me know if there's anything else I can provide or do.

PaideiaDilemma commented 1 month ago

@AndreasBackx

A few things regarding your logs:

  1. pidof lock || lock does not seem to work since [LOG] onLockFinished called. Seems we got yeeten. Is another lockscreen running?
  2. Can you post /home/andreasbackx/.cache/hyprland/hyprlandCrashReport3682.txt? (That is the hyprland crash)
  3. Does not contain any information about the hyprlock crash (which needs to happen for the weird screen to show)

Have you used coredumpctl before? Maybe you can actually recover some stack traces with that.

But I think I know why your desktop shows trough. That is a Hyprland bug. Will fix that soon.