hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
305 stars 48 forks source link

Improve Makefile to match the spec of Hyprland Makefile, and improve installing steps by creating directories beforehand #117

Closed Frontear closed 1 year ago

Frontear commented 1 year ago

EDIT: Converted to draft because there are a lot of missing steps compared to Meson, such as described in #95

TODO:

Why?

My original goal for this MR was not to actually match Hyprland's Makefile, that was more of a "eh, why not" decision. My main goal was to add some mkdir -p to the installation task so that copying the various build artifacts would succeed in cases of package managers.

I've created and maintain a separate PKGBUILD for Arch Linux that builds this portal, and time and time again I've been forced to use the meson because the current Makefile does not create the directories but rather assumes they exist. Obviously this isn't a fault of the Makefile, since in a reasonable system with all the correct dependencies these files would already exist, but it leaves problems for when I need to create the file system hierarchy in an isolated packaging environment.

What's changed?

Ready to merge?

Not yet

Frontear commented 1 year ago

Closing because of a lack of time