hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
305 stars 48 forks source link

Broken and huge cpu usage after selecting #147

Closed diniamo closed 10 months ago

diniamo commented 10 months ago

As said in the title, after pressing screenshare in an application, and selecting something, the screenshare doesn't start, and xdg-desktop-portal-hyprland starts using a huge amount of cpu until killed.

3 different people have managed to reproduce this on vencord and firefox.

Logs from vencord incident:

[LOG] execAndGet: WAYLAND_DISPLAY=wayland-1 QT_QPA_PLATFORM="wayland" XCURSOR_SIZE=30 HYPRLAND_INSTANCE_SIGNATURE=6cd82d948f93be98d0fe5516722a9228f22315d1_1703953593 XDPH_WINDOW_SHARING_LIST="788685808[HC>]VencordDesktop[HT>]• Discord | #important | diniamo's stuff[HE>]788666096[HC>]foot[HT>]/usr/lib/xdg-desktop-portal-hyprland[HE>]788661248[HC>]foot[HT>]diniamo@diniamo:~[HE>]788638272[HC>]firefox[HT>]New Tab — Mozilla Firefox[HE>]788687392[HC>]foot[HT>]btop[HE>]788687168[HC>]firefox[HT>]New Issue · hyprwm/xdg-desktop-portal-hyprland — Mozilla Firefox[HE>]" hyprland-share-picker 2>&1
[LOG] [sc] Selection: /screen:DP-1

[LOG] [screencopy] SHAREDATA returned selection 0
[LOG] [screencopy] Session destroyed
[LOG] [toplevel] (deactivate) locks: 0
[LOG] [toplevel] unbound manager
[LOG] [toplevel] (activate) locks: 1
not a valid new object id (4278190095), message toplevel(n)
[LOG] [toplevel] Activated, bound to 55fe2f026350, toplevels: 0
[LOG] [screencopy] New session:
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/request/1_68/webrtc_654540278
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/session/1_68/webrtc_session37889182
[LOG] [screencopy]  | appid: 
[LOG] [screencopy] SelectSources:
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/request/1_68/webrtc1062513835
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/session/1_68/webrtc_session37889182
[LOG] [screencopy]  | appid: 
[LOG] [screencopy] option persist_mode to 1
[LOG] [screencopy] unused option multiple
[LOG] [screencopy] unused option types
[LOG] [screencopy] restore data invalid / missing, prompting
[LOG] execAndGet: WAYLAND_DISPLAY=wayland-1 QT_QPA_PLATFORM="wayland" XCURSOR_SIZE=30 HYPRLAND_INSTANCE_SIGNATURE=6cd82d948f93be98d0fe5516722a9228f22315d1_1703953593 XDPH_WINDOW_SHARING_LIST="" hyprland-share-picker 2>&1
[LOG] [sc] Selection: /screen:DP-1

[LOG] [screencopy] SHAREDATA returned selection 0
[LOG] [screencopy] Start:
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/request/1_68/webrtc1175420133
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/session/1_68/webrtc_session37889182
[LOG] [screencopy]  | appid: 
[LOG] [screencopy]  | parent_window: 
[ERR] [screencopy] Couldn't obtain a format from dma

24141c05c27dd8b5005c938ec48530b2b5b6714a is the first bad commit.

vaxerski commented 10 months ago

check with above, should fix. Disables the feature, temporairly.

diniamo commented 10 months ago

Yes, that did it.