search

hyprwm / xdg-desktop-portal-hyprland

xdg-desktop-portal backend for Hyprland
BSD 3-Clause "New" or "Revised" License
273 stars 47 forks source link

[CMake] Fails to auto-start via DBus activation due to relative path #159

Closed jbeich closed 8 months ago

jbeich commented 8 months ago

Regressed by #154 due to using CMAKE_INSTALL_LIBEXECDIR without _FULL infix.

$ cmake -DCMAKE_INSTALL_PREFIX:PATH=/tmp/xdg-desktop-portal-hyprland_prefix -B /tmp/xdg-desktop-portal-hyprland_build -G Ninja
$ cmake --build /tmp/xdg-desktop-portal-hyprland_build
$ cmake --install /tmp/xdg-desktop-portal-hyprland_build
$ fgrep Exec /tmp/xdg-desktop-portal-hyprland_prefix/share/dbus-1/services/org.freedesktop.impl.portal.desktop.hyprland.service
Exec=libexec/xdg-desktop-portal-hyprland
fufexan commented 8 months ago

Should we use _FULL everywhere?

jbeich commented 8 months ago

Mainly with configure_file

fufexan commented 8 months ago

Mainly with configure_file

So, only for set(LIBEXECDIR ...)?

jbeich commented 8 months ago

Yep, install works fine after 86a94c3e4edb.

fufexan commented 8 months ago

Done in 1c802128f6cc3db29a8ef01552b1a22f894eeefd.

jbeich commented 8 months ago

I confirm, works fine now.